Conversation
|
✨ Coder.com for PR #4319 deployed! It will be updated on every commit.
|
jsjoeio
left a comment
There was a problem hiding this comment.
This is so exciting!!! 🎉
Great work @TeffenEllis 🚀
Requesting changes only to ask if you don't mind updating this reply from Ranger - it's a bot which auto-responds and closes issues labeled extension-request. I'm wondering if we should also remove the issue template and remove the bot response all together?
| ```bash | ||
| export SERVICE_URL=https://open-vsx.org/vscode/gallery | ||
| export ITEM_URL=https://open-vsx.org/vscode/item | ||
| export EXTENSIONS_GALLERY='{"serviceUrl": "https://extensions.coder.com/api"}' |
There was a problem hiding this comment.
Do we still support SERVICE_URL and ITEM_URL or is this a breaking change?
There was a problem hiding this comment.
nvm, saw the implementation, we may want to make a note in the changelog so we remember to update the enterprise product 📓 (or maybe we can use the old vars as fallbacks)
There was a problem hiding this comment.
Yep, the two env’s have been replaced with the single EXTENSIONS_GALLERY as Microsoft upstream is now defining several keys we’d need to override. IMO, the empty env ITEM_URL= code-server … also had some tricky ergonomics.
658721a to
95394e4
Compare
|
I think we need to fix this failing unit test. I was going to use ● /_static › disabled authentication › should return a 404 when a file is not provided
expect(received).toContain(expected) // indexOf
Expected substring: "not found"
Received string: "Not Found"
45 |
46 | const content = await resp.json()
> 47 | expect(content.error).toContain(NOT_FOUND.message)
| ^
48 | }) |
jsjoeio
left a comment
There was a problem hiding this comment.
All looks good! Only putting "Request changes" to make sure we fix that unit test before approving and merging
| export interface ClientConfiguration { | ||
| codeServerVersion: string | ||
| base: string | ||
| csStaticBase: string | ||
| } |
There was a problem hiding this comment.
ah-HA! My PR for the e2e test fix needed this!
1e98c4e to
6a53c2b
Compare
Codecov Report
@@ Coverage Diff @@
## main #4319 +/- ##
=======================================
Coverage 66.46% 66.46%
=======================================
Files 30 30
Lines 1625 1625
Branches 330 330
=======================================
Hits 1080 1080
Misses 463 463
Partials 82 82 Continue to review full report at Codecov.
|
jsjoeio
left a comment
There was a problem hiding this comment.
LGTM! 👍
(P.S. automerge may not work - at least it hasn't been working for me)
|
If we fix the conflicts, is this ready to be merged? |
- Remove extension related github configs. - Update tests to reflect new upstream behavior.
f68b493 to
4ca05c2
Compare
Rebase merges are not allowed on this repository
This PR continues the work set in place by Oxy in #2659, migrating our default configuration extension marketplace to VSX. We’ve received reports of extensions refusing to install, or exhibiting odd behaviors. I believe this is one part due to outdated extensions in our marketplace, and another regarding Microsoft’s upstream changes to determine what makes an extension “web compatible."
See coder/vscode@5f00e79 for additional implementation details.
Closes #1473