These look very specific to your use case, and not very elegant in their interface. Would a single function (not split between regexp and regular matches), that passes the matched string, an editor state, and from/to positions, work for you? I guess you're trying to optimize by passing in the data structures that are locally available, but that feels like it leaks too much of the internal implementation, and needlessly complicates the signatures.

Yeah, this is just some minimal changes that would allow me to do the filtering I wanted to do, using the same signature as the test function used internally.

Would a single function (not split between regexp and regular matches), that passes the matched string, an editor state, and from/to positions, work for you?

Yes, that should work. I do a regex test on the whole line (of the match) and use to and from for my filtering.

I've now updated the PR to use a single test function that is passed the matched string, state, and from/to positions like you suggested.

Thanks, that looks much better. I've merged this as d554699

Thanks! Feels good to be back on the official @codemirror/search package, instead of a copied monstrosity :).