Updates Semaphore CI Service for 2.0#132
Updates Semaphore CI Service for 2.0#132eddiemoore merged 2 commits intocodecov:masterfrom ChristianJacobsen:master
Conversation
Semaphore launched their 2.0 on November 6th 2018. The current Semaphore Service is using environment variables no longer present with Semaphore 2.0. I've purposefully removed the `build` and `slug` tags from the generated config as there is no good equivalent with Semaphore 2.0 anymore. List of 'git env vars' can be found at https://docs.semaphoreci.com/article/12-environment-variables
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=======================================
Coverage 89.36% 89.36%
=======================================
Files 21 21
Lines 329 329
Branches 80 80
=======================================
Hits 294 294
Misses 35 35
Continue to review full report at Codecov.
|
|
@ChristianJacobsen Perhaps the |
|
@eddiemoore The |
|
Yeah that would probably work. |
As requested, the `build` tag has been added back to the config and will now be read from the `SEMAPHORE_WORKFLOW_ID` as it's unique per 'run through the CI pipeline'.
|
@eddiemoore Think that did the trick! 😄 |
|
Hey all, thanks for this change. Am using Semaphore 2.0 and would benefit from this change 🙏 Am wondering though, this change would break retro-compatibility with Semaphore 1.x no? |
|
@fabiendem, yes this would break Semaphore 1.x compatibility. |
Semaphore launched their 2.0 on November 6th 2018. The current Semaphore Service is using environment variables no longer present with Semaphore 2.0. I've purposefully removed the
buildandslugtags from the generated config as there is no good equivalent with Semaphore 2.0 anymore. List of 'git env vars' can be found here.If the
buildand/orslugtag is needed, I will find a suitable way of extracting them from the environment variables provided.