Implemented encoding constraints in SwissQRCode and GiroCode payloads #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Owner
|
Looks good. API approvals change because of the overridden members; just run API tests locally and it should update the API approval files. |
Collaborator
Author
Worked like a charm. :-) |
Shane32
approved these changes
May 23, 2024
This was referenced Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a payload type needs a specific eci mode/ecc level/version it should override the respecting parameters in the PayloadGenerator base class. Thus users don't have to set these values manually. Unfortunately some payload generators weren't updated after this feature (encoding parameters via payload) was added. This PR brings in the necessary changes/constraints.
This PR fixes/implements the following bugs/features:
Test plan
PR contains test cases.
Closing issues
Fixes #525