-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
enhancementA new feature or feature requestA new feature or feature request
Description
Type of issue
[x] Enhancement
Expected Behavior
If a payload type needs a specific eci mode/ecc level/version it should override the respecting parameters in the PayloadGenerator base class. Thus users don't have to set these values manually. Unfortunately some payload generators weren't updated after this feature (encoding parameters via payload) was added. Namely these are:
Girocode: requires ECC-LevelM(see: https://github.com/codebude/QRCoder/wiki/Advanced-usage---Payload-generators#good-to-know-6)SwissQrCode: requires ECC-LevelMundEciMode.Utf8(see: https://github.com/codebude/QRCoder/wiki/Advanced-usage---Payload-generators#good-to-know-17)
Solution
Override respecting encoding properties in the payload generator classes.
If someone is willing to fix this, just send in a PR. Otherwise I'll pick up the topic as soon as I find some spare time.
Metadata
Metadata
Assignees
Labels
enhancementA new feature or feature requestA new feature or feature request