Normalize plugin-entry path assertion across platforms#4526
Open
biggameking wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configPathassertion inplugin-entry.test.tsWhy
This test currently hard-codes a
/profiles/today/opencode.jsonsuffix, so it fails on Windows even though the production behavior is correct. The issue is cross-platform and test-only.Testing
bun test src/hooks/auto-update-checker/checker/plugin-entry.test.tsNotes
bun.lock,assets/oh-my-opencode.schema.json) out of this PR.Summary by cubic
Fix cross-platform test by normalizing
configPathassertion inplugin-entry.test.ts, replacing a hard-coded POSIX suffix with a normalizedpath.join(profileConfigDir, "opencode.json")comparison so tests pass on Windows.Written for commit b131d4b. Summary will update on new commits. Review in cubic