Fix primary agent model precedence#3428
Conversation
|
All contributors have signed the CLA. Thank you! ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: This PR deliberately flips model precedence logic, which is a functional change that alters existing behavior and breaks previous test expectations.
|
I have read the CLA Document and I hereby sign the CLA |
|
[sisyphus-bot] PR sweep first-pass triage on
Awaiting a first-pass review. Assigning |
|
[sisyphus-bot] Hi afafara. 🙏 Thanks for putting this together; I read through the entire patch and I want to be transparent about why I'm not landing it without a maintainer pass. What the code does, accurately
Where I'd like maintainer input before this lands This PR inverts the precedence that the existing tests on
That's a semantic change, not a bug fix. The existing behavior on dev was an intentional design decision (the test names spell it out), and reversing it changes behavior for every user who relied on Two things that would unblock
Smaller observations
Once the precedence direction is confirmed by a maintainer, I'm happy to come back and finish the review. |
eb25d29 to
2bfad49
Compare
Summary
src/agents/utils.test.tsTesting
Summary by cubic
Fix model precedence for primary agents so the UI-selected model always wins over agent and category overrides. Atlas and Sisyphus now keep the runtime-selected model and restore the resolved variant when applicable.
uiSelectedModelforatlasandsisyphuseven when overrides specify a model or category.Written for commit d62cdfe. Summary will update on new commits.