Update Flutter plugin URL template for downloads #189
Conversation
Codacy's Analysis Summary0 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Pull request overview
This PR updates the Flutter plugin's download URL template to use a dynamic extension placeholder instead of a hardcoded .zip extension, aligning it with how other runtime plugins handle different archive formats across operating systems.
Changes:
- Modified the
url_templatein Flutter plugin configuration to use{{.Extension}}instead of hardcoded.zip
Comments suppressed due to low confidence (1)
plugins/runtimes/flutter/plugin.yaml:9
- The ExtensionConfig struct only supports 'windows' and 'default' fields. The 'linux' field will be ignored by the GetExtension function, which only checks for 'windows' and falls back to 'default' for all other OSes. Either the ExtensionConfig struct needs to be updated to support OS-specific extensions beyond Windows, or the linux entry should be removed and default should be set to 'tar.xz' if that's the intended extension for all non-Windows platforms.
extension:
default: "zip"
linux: "tar.xz"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,8 +1,8 @@ | |||
| name: flutter | |||
| description: Dart Flutterruntime | |||
There was a problem hiding this comment.
Missing space between 'Flutter' and 'runtime'. Should be 'Dart Flutter runtime'.
| description: Dart Flutterruntime | |
| description: Dart Flutter runtime |
No description provided.