Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Upgrade @types/classnames version#20

Merged
nathanstilwell merged 1 commit intomasterfrom
koorosh/upgrade-types-classnames
Jun 17, 2020
Merged

Upgrade @types/classnames version#20
nathanstilwell merged 1 commit intomasterfrom
koorosh/upgrade-types-classnames

Conversation

@koorosh
Copy link
Copy Markdown
Contributor

@koorosh koorosh commented May 19, 2020

Sync @typing/classnames version with classnames version

craig bot pushed a commit to cockroachdb/cockroach that referenced this pull request May 27, 2020
47484: ui: CSS modules for BarCharts components r=koorosh a=koorosh

Depends on: #47417
Depends on: cockroachdb/yarn-vendored#20
Related to: #47527

Current draft is just example for possible styles isolation with CSS modules.
It is required to make components self-contained and easy for extraction.

Before all css files were loaded into
global scope even if file was imported in
some particular module.

Now it is possible to define styles as before
and use old styles without changes, and as a
module, to do this - files has to be named as
someName.module.styl
In webpack config, `style-loader` is defined
two times with different file name matchers
to be able define style loaders with and without
modules.

`barCharts` component is a first candidate to try out css modules.
- all styles related to `barCharts` are copied(!) to `barCharts.module.styl` file,
so in case another component somehow relies on styles defined for barCharts
- it won't be affected.

Storybook is extended with stories related to `barCharts`


Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
@nathanstilwell nathanstilwell merged commit c41cdb0 into master Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants