Add new CI pipeline#84
Merged
bdarnell merged 6 commits intocockroachdb:masterfrom Jun 17, 2019
ckoehn:feature/new-pipeline
Merged
Add new CI pipeline#84bdarnell merged 6 commits intocockroachdb:masterfrom ckoehn:feature/new-pipeline
bdarnell merged 6 commits intocockroachdb:masterfrom
ckoehn:feature/new-pipeline
Conversation
This changeset adds a dedicated test job for each combination of python and CockroachDB. Signed-off-by: Christian Köhn <christian@ckoehn.de>
Contributor
Author
|
Note to me: This approach might be simplyfied by using parametrization instead of using YAML anchors. |
Signed-off-by: Christian Köhn <christian@ckoehn.de>
Signed-off-by: Christian Köhn <christian@ckoehn.de>
Contributor
Author
|
Using |
bdarnell
reviewed
Jun 11, 2019
Contributor
bdarnell
left a comment
There was a problem hiding this comment.
Thanks, Christian!
This looks good, although it's unfortunate that there's so much repetition of the cockroach and python versions. That will be annoying as we add more versions of each (although one version of python 2 and one version of python 3 is probably enough).
Signed-off-by: Christian Köhn <christian@ckoehn.de>
Signed-off-by: Christian Köhn <christian@ckoehn.de>
Signed-off-by: Christian Köhn <christian@ckoehn.de>
Contributor
|
Thanks for doing this work! I don't have comments at this time, but that's because my python-fu is not that advanced. |
Contributor
|
Thanks, looks good now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the failed pipeline in #82 and saw that the current pipeline is suboptimal and could be improved. I tried to modularize it as much as possible and use parallel jobs to test all combinations of python (py27 and py37) with the latest two stable CockroachDB releases.
Eventually this setup should include a build and deploy step to automatically release a new version once a PR is merged to master and all tests are green, but this is probably a different task.
@bdarnell @knz