Fix handling of unknown types#82
Merged
bdarnell merged 3 commits intocockroachdb:masterfrom Nov 27, 2019
Merged
Conversation
Author
|
The tests passed, build failure appears to be because of a missing dependency in the CI environment. |
Merged
When the dialect encounters an unknown type it tries to instantiate NULLTYPE which is not callable. This removes that and correctly passes it as a sentinel value.
4e2e035 to
c2a0b4f
Compare
Author
|
I just noticed #84, rebased with master. |
Contributor
|
Thanks for the contribution and for updating the PR! I just have one request (shared with #31 (comment)): can you please add a test that actually executes this line? |
added 2 commits
November 27, 2019 12:58
This test creates a column with a known type, removes the type from the type map, then attempts to find the type from the database. This should return `NULLTYPE`. A warning thrown by `get_columns` has to be suppressed for the test to pass.
Author
|
I've added a test, and confirmed that is was failing before the change I made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the dialect encounters an unknown type it tries to instantiate
NULLTYPE which is not callable. This removes that and correctly passes
it as a sentinel value.
Essentially an updated version of #31