Skip to content

Add an initial state for testing cockroachdb/cockroach#7429#13

Merged
tbg merged 1 commit intomasterfrom
initial-state
Jun 24, 2016
Merged

Add an initial state for testing cockroachdb/cockroach#7429#13
tbg merged 1 commit intomasterfrom
initial-state

Conversation

@tbg
Copy link
Copy Markdown
Member

@tbg tbg commented Jun 23, 2016

This change is Reviewable

tbg added a commit to tbg/cockroach that referenced this pull request Jun 24, 2016
Also straightened out some kinks with the existing reference tests, namely that
they were creating two single-node clusters per test which were never used.
Instead, we can now create zero-node clusters and run one-shot containers on
it (one would argue that that's still weird, but it seems acceptable for the
time being).

The newly added reference test will crash when run for commits between cockroachdb#7310
and cockroachdb#7429. See cockroachdb/postgres-test#13 for the initial state used in the
test.
@tamird
Copy link
Copy Markdown
Contributor

tamird commented Jun 24, 2016

How does this data end up getting used? Is a node ever started with this directory as its data directory?


Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


cockroach-data-beta-20160414/README, line 4 [r1] (raw file):

to disable the Raft log queue) and the following shell script:

  rm -rf cockroach-data

care to make this a code-like block?


cockroach-data-beta-20160414/README, line 13 [r1] (raw file):

  killall -9 cockroach

Its purpose is to create an initial state which is vulnerable to #7389 when

put full links here - you're in a different repo now


Comments from Reviewable

@tbg
Copy link
Copy Markdown
Member Author

tbg commented Jun 24, 2016

Review status: all files reviewed at latest revision, 2 unresolved discussions.


cockroach-data-beta-20160414/README, line 4 [r1] (raw file):

Previously, tamird (Tamir Duberstein) wrote…

care to make this a code-like block?

Done.

cockroach-data-beta-20160414/README, line 13 [r1] (raw file):

Previously, tamird (Tamir Duberstein) wrote…

put full links here - you're in a different repo now

Done.

Comments from Reviewable

@tbg tbg force-pushed the initial-state branch from 4a35f6c to 533279f Compare June 24, 2016 00:42
@tbg
Copy link
Copy Markdown
Member Author

tbg commented Jun 24, 2016

Yes, see the main PR cockroachdb/cockroach#7429.


Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

tbg added a commit to tbg/cockroach that referenced this pull request Jun 24, 2016
Also straightened out some kinks with the existing reference tests, namely that
they were creating two single-node clusters per test which were never used.
Instead, we can now create zero-node clusters and run one-shot containers on
it (one would argue that that's still weird, but it seems acceptable for the
time being).

The newly added reference test will crash when run for commits between cockroachdb#7310
and cockroachdb#7429. See cockroachdb/postgres-test#13 for the initial state used in the
test.
@tamird
Copy link
Copy Markdown
Contributor

tamird commented Jun 24, 2016

:lgtm:


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


cockroach-data-beta-20160414/README.md, line 13 [r1] (raw file):

Previously, tschottdorf (Tobias Schottdorf) wrote…

Done.

gotta do a full link it seems

cockroach-data-beta-20160414/README.md, line 4 [r2] (raw file):

to disable the Raft log queue) and the following shell script:

may as well ```shell this


Comments from Reviewable

tbg added a commit to tbg/cockroach that referenced this pull request Jun 24, 2016
Also straightened out some kinks with the existing reference tests, namely that
they were creating two single-node clusters per test which were never used.
Instead, we can now create zero-node clusters and run one-shot containers on
it (one would argue that that's still weird, but it seems acceptable for the
time being).

The newly added reference test will crash when run for commits between cockroachdb#7310
and cockroachdb#7429. See cockroachdb/postgres-test#13 for the initial state used in the
test.
@tbg tbg force-pushed the initial-state branch from 533279f to 0327fbc Compare June 24, 2016 01:09
tbg added a commit to tbg/cockroach that referenced this pull request Jun 24, 2016
Also straightened out some kinks with the existing reference tests, namely that
they were creating two single-node clusters per test which were never used.
Instead, we can now create zero-node clusters and run one-shot containers on
it (one would argue that that's still weird, but it seems acceptable for the
time being).

The newly added reference test will crash when run for commits between cockroachdb#7310
and cockroachdb#7429. See cockroachdb/postgres-test#13 for the initial state used in the
test.
@tbg tbg merged commit 32d9a3b into master Jun 24, 2016
@tbg tbg deleted the initial-state branch June 24, 2016 01:23
tbg added a commit to tbg/cockroach that referenced this pull request Jun 24, 2016
Also straightened out some kinks with the existing reference tests, namely that
they were creating two single-node clusters per test which were never used.
Instead, we can now create zero-node clusters and run one-shot containers on
it (one would argue that that's still weird, but it seems acceptable for the
time being).

The newly added reference test will crash when run for commits between cockroachdb#7310
and cockroachdb#7429. See cockroachdb/postgres-test#13 for the initial state used in the
test.
tbg added a commit to tbg/cockroach that referenced this pull request Jun 24, 2016
Also straightened out some kinks with the existing reference tests, namely that
they were creating two single-node clusters per test which were never used.
Instead, we can now create zero-node clusters and run one-shot containers on
it (one would argue that that's still weird, but it seems acceptable for the
time being).

The newly added reference test will crash when run for commits between cockroachdb#7310
and cockroachdb#7429. See cockroachdb/postgres-test#13 for the initial state used in the
test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants