Merged
Conversation
Rename `Comparer.Format` to `Comparer.FormatKey`. This is in preparation for adding `FormatValue`.
Rename `tool.formatter` to `tool.keyFormatter` and add `tool.valueFormatter`. This allowed plumbing through the use of `Comparer.FormatValue` throughout the tool commands. Fixes #630
Collaborator
Author
|
This change is |
jbowens
approved these changes
Apr 21, 2020
Contributor
jbowens
left a comment
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, 13 of 13 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itsbilal)
jbowens
approved these changes
Apr 21, 2020
Contributor
jbowens
left a comment
There was a problem hiding this comment.
Reviewable status:
Collaborator
Author
|
TFTR! |
itsbilal
added a commit
to itsbilal/pebble
that referenced
this pull request
Apr 21, 2020
Merging cockroachdb#614 and cockroachdb#635 in quick succession broke the master build. This change updates L0SubLevels with the type rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
tool.formattertotool.keyFormatterand addtool.valueFormatter. This allowed plumbing through the use ofComparer.FormatValuethroughout the tool commands.Fixes #630