internal/rangekey: enforce iterator bounds beneath defragmentation#1866
Merged
jbowens merged 1 commit intocockroachdb:masterfrom Aug 11, 2022
Merged
internal/rangekey: enforce iterator bounds beneath defragmentation#1866jbowens merged 1 commit intocockroachdb:masterfrom
jbowens merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Enforce iterator bounds beneath defragmentation to avoid unnecessary range-key block loads. ``` name old time/op new time/op delta CombinedIteratorSeek_Bounded-10 2.77ms ± 1% 0.05ms ± 2% -98.23% (p=0.000 n=10+20) name old alloc/op new alloc/op delta CombinedIteratorSeek_Bounded-10 1.79MB ± 0% 0.02MB ± 0% -98.89% (p=0.000 n=10+19) name old allocs/op new allocs/op delta CombinedIteratorSeek_Bounded-10 17.0k ± 0% 0.1k ± 0% -99.28% (p=0.000 n=10+20) ``` Close cockroachdb#1861.
Contributor
|
Damn, those are some gains! 🚀 |
nicktrav
approved these changes
Aug 11, 2022
Contributor
nicktrav
left a comment
There was a problem hiding this comment.
Very nice.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @erikgrinaker, @itsbilal, and @sumeerbhola)
jbowens
commented
Aug 11, 2022
Contributor
Author
jbowens
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce iterator bounds beneath defragmentation to avoid unnecessary range-key
block loads.
Close #1861.