tool: fix find to support custom comparers and mergers#1104
tool: fix find to support custom comparers and mergers#1104petermattis merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
tbg
left a comment
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @petermattis and @sumeerbhola)
tool/testdata/find, line 16 at r1 (raw file):
---- 000002.log aaa#1,SET [31]
🤔 I don't understand why these have changed. Was the file just not regenerated in a while and we're picking this up from some other change?
Picks up cockroachdb/pebble#1104. Release note: None
Add support for custom comparers and mergers to `find`. This involved plumbing through the mergers from the top-level tool as was already being done for the other tool commands.
9d64218 to
c026bde
Compare
petermattis
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status: 15 of 19 files reviewed, 1 unresolved discussion (waiting on @sumeerbhola and @tbg)
tool/testdata/find, line 16 at r1 (raw file):
Previously, tbg (Tobias Grieger) wrote…
🤔 I don't understand why these have changed. Was the file just not regenerated in a while and we're picking this up from some other change?
Yes, the testdata/find-db data had not been regenerated in a while and we've picked up a change that adjusted how the first sequence number is allocated. In particular, we're picking up d2ecbc2 which changed the first seqnum to be 1 to match RocksDB. That commit landed in Mar 2020, while the testdata/find-db data had previously been updated in Jan 2020.
Add support for custom comparers and mergers to
find. This involvedplumbing through the mergers from the top-level tool as was already
being done for the other tool commands.