cockroachdb: speed up multi-register test and fix split nemesis#20
Merged
nvb merged 2 commits intotc-nightlyfrom Apr 17, 2019
Merged
cockroachdb: speed up multi-register test and fix split nemesis#20nvb merged 2 commits intotc-nightlyfrom
nvb merged 2 commits intotc-nightlyfrom
Conversation
This helps reduce the time of runs to a more reasonable limit.
Since introducing Range merges in CockroachDB v2.1, manual Range splits have only been allowed if the merge queue is disabled first. This commit disables the merge queue when the split-nemesis is in use, preventing errors like the following: ``` INFO [2019-04-17 19:32:45,072] jepsen nemesis - jepsen.util :nemesis :info ["splits" :split] nil indeterminate: ERROR: splits would be immediately discarded by merge queue; disable the merge queue first by running 'SET CLUSTER SETTING kv.range_merge.queue_enabled = false' ```
bdarnell
approved these changes
Apr 17, 2019
| :client {:client (MultiAtomicClient. (atom false) nil) | ||
| :during (independent/concurrent-generator | ||
| (count (:nodes opts)) | ||
| 3 |
There was a problem hiding this comment.
Why is this 3 instead of the size of the cluster like it was before?
Author
There was a problem hiding this comment.
Reducing the concurrency sped up the test. Setting this to the size of the cluster was somewhat arbitrary. Tests like comments do that but tests like register set it to a constant value.
aliher1911
pushed a commit
to aliher1911/jepsen
that referenced
this pull request
Dec 24, 2021
Test the exit code, not the message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for cockroachdb/cockroach#36616.