Conversation
This picks up the option to start a tenant proxy. It also fixes up the certificates used for tenants.
Switch to an options-struct pattern to de-noise the test. This was prompted by the need to add an option that will only be used by a few tests, in a future commit.
Member
|
This change is |
rafiss
approved these changes
Aug 19, 2020
Contributor
rafiss
left a comment
There was a problem hiding this comment.
nice, thank you for the updates
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @rafiss and @tbg)
testing/main_test.go, line 403 at r4 (raw file):
tableNames: djangoTestTableNames, columnNames: djangoTestColumnNames, // No support for client certs (at least not via the query string).
seems like it would work with making a settings.py, but i guess that would be too large of a refactor?
https://stackoverflow.com/questions/35869001/django-connection-to-postgresql-using-cert-authentication
Member
Author
|
Yeah, I think (hope) that all of these could actually work, at least through the proxy (where all you need is server ssl and password auth), but I didn't want to get into that in the first PR. My end goal is that, though, so there will be more. TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that even though we had introduced functionality to run against
secure CRDB in cockroach-go, we had never actually started to use it here.
This series of commits fixes that.
Unfortunately, it turns out that this won't just work out of the box for
many of the ORMs, and we have to stay insecure. Notably:
the certs
This leaves only GORM, SQLAlchemy, and ActiveRecord actually running securely.
Interestingly, the tenant proxy, which I originally intended to use here,
could make this work better since it does not require client certs.