Update SHOW RANGE FOR ROW to take indexed columns#8634
Conversation
|
This change is |
|
Looks good to me, but @solongordon should give it the final stamp :) |
solongordon
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jseldess, @rohany, and @solongordon)
v20.2/show-range-for-row.md, line 19 at r1 (raw file):
~~~ SHOW RANGE FROM TABLE <tablename> FOR ROW (row, value, ...) SHOW RANGE FROM INDEX [ <tablename> @ ] <indexname> FOR ROW (row, value, ...)
Nit: I find the (row, value, ...) terminology kind of confusing. It seems to imply that the first element is a row and the second one is a value. Perhaps better to write something like (value1, value2, ...)?
|
v20.2/show-range-for-row.md, line 19 at r1 (raw file): Previously, solongordon (Solon) wrote…
I agree. I like your suggestion better. I got this syntax directly from the CLI help text in sql.y: https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/parser/sql.y#L4991. I'll change it here and also open a cockroach PR to change the help text. |
ab4dd4f to
7b597e2
Compare
The SHOW RANGE FOR ROW statement now accepts the indexed values of the row as a tuple. The help text representation of this was previous (row, value, ...). The help text representation is now (value1, value2, ...), which I believe is clearer. Counterpart to this docs PR: cockroachdb/docs#8634 Release note: None
Unrelated to this PR. Somehow these broken links made there way onto master.
55474: sql: clarify help text for `show range` r=solongordon a=jseldess The SHOW RANGE FOR ROW statement now accepts the indexed values of the row as a tuple. The help text representation of this was previous (row, value, ...). The help text representation is now (value1, value2, ...), which I believe is clearer. Counterpart to this docs PR: cockroachdb/docs#8634 Release note: None Co-authored-by: Jesse Seldess <j_seldess@hotmail.com>
Fixes #7821.