Release notes v20.2.0 alpha.1 and v20.1.2#7484
Conversation
|
This change is |
6faa855 to
30c676e
Compare
ericharmeling
left a comment
There was a problem hiding this comment.
This is an enormous release notes PR. It's a little shocking, TBH. Awesome job!
I added a few grammar nits, but most of my comments here are about removing vestiges of "release justifications" and linking to other pages in our docs. I know adding links to release notes is super time-consuming, but I imagine that it's very useful for the people who read the notes. I wonder if we want to discuss with the docs team whether or not it's worth the effort to add links to other docs in release notes?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling and @rmloveland)
releases/v20.2.0-alpha.1.md, line 42 at r1 (raw file):
`cockroach quit`
Link to cockroach-quit.html.
releases/v20.2.0-alpha.1.md, line 43 at r1 (raw file):
Scripts who wish
*nit
Scripts that wish
releases/v20.2.0-alpha.1.md, line 44 at r1 (raw file):
`cockroach debug zip`
Link to cockroach-debug-zip.html.
releases/v20.2.0-alpha.1.md, line 45 at r1 (raw file):
`cockroach start`
Link to cockroach-start.html.
releases/v20.2.0-alpha.1.md, line 45 at r1 (raw file):
is experimental. However, it is also found
*nit
is experimental, and has been found
releases/v20.2.0-alpha.1.md, line 50 at r1 (raw file):
Release justification: fix for new "functionality" - the reduction in the closed timestamp target duration.
This can be removed.
releases/v20.2.0-alpha.1.md, line 51 at r1 (raw file):
Schema changes started in 19.2 will now be automatically migrated in the background in 20.1 after upgrade finalization so that they can run to completion.
Does this mean that people start schema migrations in 19.2 and then upgrade while the migrations are still in progress? I mean "run it", but the sentence just don't make a lot of sense to me.
releases/v20.2.0-alpha.1.md, line 52 at r1 (raw file):
cluster setting
Link to cluster-settings.html.
releases/v20.2.0-alpha.1.md, line 53 at r1 (raw file):
Statement diagnostics zip bundles
Link to that page.
releases/v20.2.0-alpha.1.md, line 53 at r1 (raw file):
Jaeger
Link to Jaeger site.
releases/v20.2.0-alpha.1.md, line 54 at r1 (raw file):
replication constraints
Link to configure-replication-zones.html.
releases/v20.2.0-alpha.1.md, line 57 at r1 (raw file):
musl libc
Should these be in code tags?
releases/v20.2.0-alpha.1.md, line 64 at r1 (raw file):
`BACKUP`
Link to backup.html.
releases/v20.2.0-alpha.1.md, line 64 at r1 (raw file):
`RESTORE`
Link to restore.html.
releases/v20.2.0-alpha.1.md, line 64 at r1 (raw file):
Release justification: low-risk, high impact.
This can be removed.
releases/v20.2.0-alpha.1.md, line 65 at r1 (raw file):
`SHOW BACKUP`
Link to show-backup.html.
releases/v20.2.0-alpha.1.md, line 65 at r1 (raw file):
Release justification: low risk, high impact change to existing functionality.
This can be removed.
releases/v20.2.0-alpha.1.md, line 67 at r1 (raw file):
incremental backup
Link to backup.html#create-incremental-backups.
releases/v20.2.0-alpha.1.md, line 68 at r1 (raw file):
locations requires
locations now require
releases/v20.2.0-alpha.1.md, line 77 at r1 (raw file):
will have
will now have
releases/v20.2.0-alpha.1.md, line 108 at r1 (raw file):
`IMPORT`
Link to import.html.
releases/v20.2.0-alpha.1.md, line 108 at r1 (raw file):
Release justification: low-risk, high impact.
This can be removed.
releases/v20.2.0-alpha.1.md, line 109 at r1 (raw file):
`CREATE`/`ALTER`/`DROP ROLE`
Link to authorization.html.
releases/v20.2.0-alpha.1.md, line 110 at r1 (raw file):
Release justification: Low risk change, command result output changed for CREATE/ALTER/DROP ROLE. Hint added for GRANT ROLE.
This can be removed.
releases/v20.2.0-alpha.1.md, line 111 at r1 (raw file):
`ADD CONSTRAINT`
Link to add-constraint.html
releases/v20.2.0-alpha.1.md, line 114 at r1 (raw file):
vectorized execution engine
Link to vectorized-execution.html.
releases/v20.2.0-alpha.1.md, line 115 at r1 (raw file):
Release justification: none
This can be removed.
releases/v20.2.0-alpha.1.md, line 116 at r1 (raw file):
cluster setting
Link to cluster-settings.html.
releases/v20.2.0-alpha.1.md, line 117 at r1 (raw file):
`EXPLAIN`
Link to explain.html.
releases/v20.2.0-alpha.1.md, line 118 at r1 (raw file):
aggregate function
Link to functions-and-operators.html#aggregate-functions.
releases/v20.2.0-alpha.1.md, line 122 at r1 (raw file):
ALTER COLUMN
Link to alter-column.html.
releases/v20.2.0-alpha.1.md, line 123 at r1 (raw file):
`SHOW TABLES`
Link to show-tables.html.
releases/v20.2.0-alpha.1.md, line 124 at r1 (raw file):
hash sharded index creation
Link to indexes.html#hash-sharded-indexes.html.
releases/v20.2.0-alpha.1.md, line 133 at r1 (raw file):
TIMESTAMP(TZ)
Link to timestamp.html.
releases/v20.2.0-alpha.1.md, line 135 at r1 (raw file):
`ROLLBACK TO SAVEPOINT`
Link to rollback-transaction.html.
releases/v20.2.0-alpha.1.md, line 136 at r1 (raw file):
CTEs
Link to common-table-expressions.html.
releases/v20.2.0-alpha.1.md, line 138 at r1 (raw file):
session settings
Change all instances to 'session variables'.
Link to set-vars.html.
releases/v20.2.0-alpha.1.md, line 141 at r1 (raw file):
vectorized execution
Link to vectorized-execution.html.
releases/v20.2.0-alpha.1.md, line 143 at r1 (raw file):
primary key changes
Link to alter-primary-key.html.
releases/v20.2.0-alpha.1.md, line 147 at r1 (raw file):
`CHAR` data type
Link to string.html.
releases/v20.2.0-alpha.1.md, line 162 at r1 (raw file):
data types that CockroachDB supports
Link to data-types.html.
releases/v20.2.0-alpha.1.md, line 178 at r1 (raw file):
`cockroach demo`
Link to cockroach-demo.html.
releases/v20.2.0-alpha.1.md, line 181 at r1 (raw file):
`cockroach sql`,
Link to cockroach-sql.html.
releases/v20.2.0-alpha.1.md, line 184 at r1 (raw file):
is simplified to not require
now does not require
releases/v20.2.0-alpha.1.md, line 189 at r1 (raw file):
`cockroach quit`
Link
releases/v20.2.0-alpha.1.md, line 189 at r1 (raw file):
`cockroach node drain`
Link
releases/v20.2.0-alpha.1.md, line 191 at r1 (raw file):
`cockroach start` / `cockroach start-single-node`
Links
releases/v20.2.0-alpha.1.md, line 192 at r1 (raw file):
`cockroach init` and `cockroach quit`
Links
releases/v20.2.0-alpha.1.md, line 194 at r1 (raw file):
`cockroach debug zip`
Link
releases/v20.2.0-alpha.1.md, line 196 at r1 (raw file):
`cockroach dump`
Link
releases/v20.2.0-alpha.1.md, line 205 at r1 (raw file):
is permanent
is now permanent
releases/v20.2.0-alpha.1.md, line 205 at r1 (raw file):
is dismissed
is now dismissed
releases/v20.2.0-alpha.1.md, line 208 at r1 (raw file):
are limited
are now limited
releases/v20.2.0-alpha.1.md, line 209 at r1 (raw file):
is always
is now always
releases/v20.2.0-alpha.1.md, line 217 at r1 (raw file):
- Fixed a bug where sort columns were only being applied per-page instead of for the entire multi-page list of statements. [#46416][#46416]
Duplicate - can remove
releases/v20.2.0-alpha.1.md, line 233 at r1 (raw file):
"Network Latency"
Pages haven't used quotations in the rest of these notes.
releases/v20.2.0-alpha.1.md, line 240 at r1 (raw file):
Show default error message about restricted permissions for non-admin users on the Databases page.
The Databases page now shows default error message about restricted permissions for non-admin users.
releases/v20.2.0-alpha.1.md, line 244 at r1 (raw file):
Ensure that index and table GC happen closer
Index and table GC now happen closer
releases/v20.2.0-alpha.1.md, line 248 at r1 (raw file):
EXPLAIN ANALYZE (DEBUG)
Link to explain-analyze.html
releases/v20.2.0-alpha.1.md, line 249 at r1 (raw file):
`RESTORE`
Link
releases/v20.2.0-alpha.1.md, line 250 at r1 (raw file):
IMPORT
Link
releases/v20.2.0-alpha.1.md, line 257 at r1 (raw file):
`cockroach demo`
Link
releases/v20.2.0-alpha.1.md, line 258 at r1 (raw file):
`TIME`
Link
releases/v20.2.0-alpha.1.md, line 262 at r1 (raw file):
Return a proper
CockroachDB now returns a proper
releases/v20.2.0-alpha.1.md, line 264 at r1 (raw file):
`BACKUP`
Link
releases/v20.2.0-alpha.1.md, line 266 at r1 (raw file):
Fix
Fixed
releases/v20.2.0-alpha.1.md, line 266 at r1 (raw file):
`SELECT` statements
Link
releases/v20.2.0-alpha.1.md, line 267 at r1 (raw file):
`TIMETZ`
Link
releases/v20.2.0-alpha.1.md, line 268 at r1 (raw file):
foreign key constraint
Link
releases/v20.2.0-alpha.1.md, line 277 at r1 (raw file):
the occurred
that occurred
releases/v20.2.0-alpha.1.md, line 281 at r1 (raw file):
hash sharded indexes
Link
releases/v20.2.0-alpha.1.md, line 285 at r1 (raw file):
`ARRAY`
Link
releases/v20.2.0-alpha.1.md, line 286 at r1 (raw file):
[a store is]
Are the brackets intentional here?
releases/v20.2.0-alpha.1.md, line 287 at r1 (raw file):
`TRUNCATE`
Link
releases/v20.2.0-alpha.1.md, line 287 at r1 (raw file):
temporary tables
Link
releases/v20.2.0-alpha.1.md, line 292 at r1 (raw file):
INTERVAL`s or `TIMESTAMP`s to type `DECIMAL`
Links
releases/v20.2.0-alpha.1.md, line 294 at r1 (raw file):
SHOW RANGES` or `SHOW RANGE FOR ROW`
Link
releases/v20.2.0-alpha.1.md, line 302 at r1 (raw file):
`PARTITION BY` and `ORDER BY`
Links
releases/v20.2.0-alpha.1.md, line 303 at r1 (raw file):
`EXPLAIN (VERBOSE)`
Link
releases/v20.2.0-alpha.1.md, line 304 at r1 (raw file):
`DROP INDEX`
Link
releases/v20.2.0-alpha.1.md, line 304 at r1 (raw file):
UNIQUE`
Link
releases/v20.2.0-alpha.1.md, line 307 at r1 (raw file):
vectorized engine
Link
releases/v20.2.0-alpha.1.md, line 308 at r1 (raw file):
`cockroach debug zip`
Link
releases/v20.2.0-alpha.1.md, line 312 at r1 (raw file):
`cockroach debug encryption-status`
Link
releases/v20.2.0-alpha.1.md, line 317 at r1 (raw file):
DROP COLUMN
Link
releases/v20.2.0-alpha.1.md, line 324 at r1 (raw file):
`SHOW STATISTICS USING JSON`
Link
releases/v20.2.0-alpha.1.md, line 325 at r1 (raw file):
`ADD` or `RENAME` a column
Link
releases/v20.2.0-alpha.1.md, line 340 at r1 (raw file):
primary key change.
Link
releases/v20.2.0-alpha.1.md, line 344 at r1 (raw file):
SHOW BACKUP SCHEMAS`
Link
releases/v20.2.0-alpha.1.md, line 356 at r1 (raw file):
`BYTES` type
Link
releases/v20.2.0-alpha.1.md, line 357 at r1 (raw file):
Report engine type correctly
CockroachDB now correctly reports engine type
releases/v20.2.0-alpha.1.md, line 361 at r1 (raw file):
Stop leaking file
CockroachDB no longer leaks file
releases/v20.2.0-alpha.1.md, line 373 at r1 (raw file):
`BACKUP`
Link
releases/v20.2.0-alpha.1.md, line 374 at r1 (raw file):
query optimizer
Link
releases/v20.2.0-alpha.1.md, line 376 at r1 (raw file):
`UPDATE`
Link
releases/v20.2.0-alpha.1.md, line 387 at r1 (raw file):
`SHOW CREATE`
Link
releases/v20.2.0-alpha.1.md, line 389 at r1 (raw file):
Disable the Go runtime block profile by default which results in
Disabled the Go runtime block profile by default, resulting in
releases/v20.2.0-alpha.1.md, line 394 at r1 (raw file):
`DROP TABLE`
Link
releases/v20.2.0-alpha.1.md, line 396 at r1 (raw file):
Lookup joins
Link
releases/v20.2.0-alpha.1.md, line 404 at r1 (raw file):
This problem was introduced early in the development for the 20.2 release, so should not have ever been part of a release.
Should we remove this release note then?
30c676e to
aab2568
Compare
rmloveland
left a comment
There was a problem hiding this comment.
Thank you for this very detailed review, Eric! I think all comments have been addressed
Reviewable status:
releases/v20.2.0-alpha.1.md, line 42 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach quit`Link to cockroach-quit.html.
Added links to this and all other cockroach * commands.
releases/v20.2.0-alpha.1.md, line 43 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Scripts who wish*nit
Scripts that wish
Fixed
releases/v20.2.0-alpha.1.md, line 44 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach debug zip`Link to cockroach-debug-zip.html.
Done.
releases/v20.2.0-alpha.1.md, line 45 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach start`Link to cockroach-start.html.
Done.
releases/v20.2.0-alpha.1.md, line 45 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
is experimental. However, it is also found*nit
is experimental, and has been found
Done.
releases/v20.2.0-alpha.1.md, line 50 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Release justification: fix for new "functionality" - the reduction in the closed timestamp target duration.This can be removed.
Removed this, and all other mentions of "Release justification ..."
releases/v20.2.0-alpha.1.md, line 51 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Schema changes started in 19.2 will now be automatically migrated in the background in 20.1 after upgrade finalization so that they can run to completion.Does this mean that people start schema migrations in 19.2 and then upgrade while the migrations are still in progress? I mean "run it", but the sentence just don't make a lot of sense to me.
I think the answer is yes. But at the same time, we recommend against this in https://www.cockroachlabs.com/docs/stable/upgrade-cockroach-version.html#let-ongoing-bulk-operations-finish
Since this is from a commit message, I think it reflects the technical reality of having made a fix, vs. what we recommend in docs for production use.
releases/v20.2.0-alpha.1.md, line 52 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
cluster settingLink to cluster-settings.html.
Done for all uses of "cluster setting*" - also went ahead and made all links to "Session variable" and "session setting" links to SHOW (session var) page
releases/v20.2.0-alpha.1.md, line 53 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Statement diagnostics zip bundlesLink to that page.
Done.
releases/v20.2.0-alpha.1.md, line 53 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
JaegerLink to Jaeger site.
Done.
releases/v20.2.0-alpha.1.md, line 54 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
replication constraintsLink to configure-replication-zones.html.
Linked from here, and one other mention of this that I found
releases/v20.2.0-alpha.1.md, line 57 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
musl libcShould these be in
code tags?
made it a link to the web page for that lib - they seem to spell it lower-case
releases/v20.2.0-alpha.1.md, line 64 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`BACKUP`Link to backup.html.
Done, here and everywhere else
releases/v20.2.0-alpha.1.md, line 64 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`RESTORE`Link to restore.html.
Done here and elsewhere
releases/v20.2.0-alpha.1.md, line 64 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Release justification: low-risk, high impact.This can be removed.
Done.
releases/v20.2.0-alpha.1.md, line 65 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`SHOW BACKUP`Link to show-backup.html.
Done.
releases/v20.2.0-alpha.1.md, line 65 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Release justification: low risk, high impact change to existing functionality.This can be removed.
Done.
releases/v20.2.0-alpha.1.md, line 67 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
incremental backupLink to backup.html#create-incremental-backups.
Done.
releases/v20.2.0-alpha.1.md, line 68 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
locations requireslocations now require
Done.
releases/v20.2.0-alpha.1.md, line 77 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
will havewill now have
Done.
releases/v20.2.0-alpha.1.md, line 108 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`IMPORT`Link to import.html.
Done.
releases/v20.2.0-alpha.1.md, line 108 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Release justification: low-risk, high impact.This can be removed.
Done.
releases/v20.2.0-alpha.1.md, line 109 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`CREATE`/`ALTER`/`DROP ROLE`Link to authorization.html.
Done.
releases/v20.2.0-alpha.1.md, line 110 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Release justification: Low risk change, command result output changed for CREATE/ALTER/DROP ROLE. Hint added for GRANT ROLE.This can be removed.
Done.
releases/v20.2.0-alpha.1.md, line 111 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`ADD CONSTRAINT`Link to add-constraint.html
Done.
releases/v20.2.0-alpha.1.md, line 114 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
vectorized execution engineLink to vectorized-execution.html.
Linked here and elsewhere
releases/v20.2.0-alpha.1.md, line 115 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Release justification: noneThis can be removed.
Done.
releases/v20.2.0-alpha.1.md, line 116 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
cluster settingLink to cluster-settings.html.
Done.
releases/v20.2.0-alpha.1.md, line 117 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`EXPLAIN`Link to explain.html.
Done.
releases/v20.2.0-alpha.1.md, line 118 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
aggregate functionLink to functions-and-operators.html#aggregate-functions.
Done.
releases/v20.2.0-alpha.1.md, line 122 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
ALTER COLUMNLink to alter-column.html.
Done.
releases/v20.2.0-alpha.1.md, line 123 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`SHOW TABLES`Link to show-tables.html.
Done.
releases/v20.2.0-alpha.1.md, line 124 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
hash sharded index creationLink to indexes.html#hash-sharded-indexes.html.
Linked here and elsewhere
releases/v20.2.0-alpha.1.md, line 133 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
TIMESTAMP(TZ)Link to timestamp.html.
Done.
releases/v20.2.0-alpha.1.md, line 135 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`ROLLBACK TO SAVEPOINT`Link to rollback-transaction.html.
Done.
releases/v20.2.0-alpha.1.md, line 136 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
CTEsLink to common-table-expressions.html.
Done.
releases/v20.2.0-alpha.1.md, line 138 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
session settingsChange all instances to 'session variables'.
Link to set-vars.html.
Done.
releases/v20.2.0-alpha.1.md, line 141 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
vectorized executionLink to vectorized-execution.html.
Done.
releases/v20.2.0-alpha.1.md, line 143 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
primary key changesLink to alter-primary-key.html.
Updated here and elsewhere
releases/v20.2.0-alpha.1.md, line 147 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`CHAR` data typeLink to string.html.
Done.
releases/v20.2.0-alpha.1.md, line 162 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
data types that CockroachDB supportsLink to data-types.html.
Done.
releases/v20.2.0-alpha.1.md, line 178 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach demo`Link to cockroach-demo.html.
Done.
releases/v20.2.0-alpha.1.md, line 181 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach sql`,Link to cockroach-sql.html.
Done.
releases/v20.2.0-alpha.1.md, line 184 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
is simplified to not requirenow does not require
went with "is simplified to no longer require ..."
releases/v20.2.0-alpha.1.md, line 189 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach quit`Link
Done.
releases/v20.2.0-alpha.1.md, line 189 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach node drain`Link
Done.
releases/v20.2.0-alpha.1.md, line 191 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach start` / `cockroach start-single-node`Links
Done.
releases/v20.2.0-alpha.1.md, line 192 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach init` and `cockroach quit`Links
Done.
releases/v20.2.0-alpha.1.md, line 194 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach debug zip`Link
Done.
releases/v20.2.0-alpha.1.md, line 196 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach dump`Link
Done.
releases/v20.2.0-alpha.1.md, line 205 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
is permanentis now permanent
Done.
releases/v20.2.0-alpha.1.md, line 205 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
is dismissedis now dismissed
Done.
releases/v20.2.0-alpha.1.md, line 208 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
are limitedare now limited
Done.
releases/v20.2.0-alpha.1.md, line 209 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
is alwaysis now always
Done.
releases/v20.2.0-alpha.1.md, line 217 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
- Fixed a bug where sort columns were only being applied per-page instead of for the entire multi-page list of statements. [#46416][#46416]Duplicate - can remove
Done.
releases/v20.2.0-alpha.1.md, line 233 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
"Network Latency"Pages haven't used quotations in the rest of these notes.
Done.
releases/v20.2.0-alpha.1.md, line 240 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Show default error message about restricted permissions for non-admin users on the Databases page.The Databases page now shows default error message about restricted permissions for non-admin users.
Done.
releases/v20.2.0-alpha.1.md, line 244 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Ensure that index and table GC happen closerIndex and table GC now happen closer
Done.
releases/v20.2.0-alpha.1.md, line 248 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
EXPLAIN ANALYZE (DEBUG)Link to explain-analyze.html
Done.
releases/v20.2.0-alpha.1.md, line 249 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`RESTORE`Link
Done.
releases/v20.2.0-alpha.1.md, line 250 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
IMPORTLink
Done.
releases/v20.2.0-alpha.1.md, line 257 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach demo`Link
Done.
releases/v20.2.0-alpha.1.md, line 258 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`TIME`Link
Done.
releases/v20.2.0-alpha.1.md, line 262 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Return a properCockroachDB now returns a proper
Done.
releases/v20.2.0-alpha.1.md, line 264 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`BACKUP`Link
Done.
releases/v20.2.0-alpha.1.md, line 266 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
FixFixed
Done.
releases/v20.2.0-alpha.1.md, line 266 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`SELECT` statementsLink
Done.
releases/v20.2.0-alpha.1.md, line 267 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`TIMETZ`Link
Done.
releases/v20.2.0-alpha.1.md, line 268 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
foreign key constraintLink
Done.
releases/v20.2.0-alpha.1.md, line 277 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
the occurredthat occurred
Done.
releases/v20.2.0-alpha.1.md, line 281 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
hash sharded indexesLink
Done.
releases/v20.2.0-alpha.1.md, line 285 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`ARRAY`Link
Done.
releases/v20.2.0-alpha.1.md, line 286 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
[a store is]Are the brackets intentional here?
Yes, but I removed them - they were part of the note but it's not clear they are needed here
releases/v20.2.0-alpha.1.md, line 287 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`TRUNCATE`Link
Done.
releases/v20.2.0-alpha.1.md, line 287 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
temporary tablesLink
Done.
releases/v20.2.0-alpha.1.md, line 292 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
INTERVAL`s or `TIMESTAMP`s to type `DECIMAL`Links
Done.
releases/v20.2.0-alpha.1.md, line 294 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
SHOW RANGES` or `SHOW RANGE FOR ROW`Link
Done.
releases/v20.2.0-alpha.1.md, line 302 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`PARTITION BY` and `ORDER BY`Links
Done.
releases/v20.2.0-alpha.1.md, line 303 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`EXPLAIN (VERBOSE)`Link
Done.
releases/v20.2.0-alpha.1.md, line 304 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`DROP INDEX`Link
Done.
releases/v20.2.0-alpha.1.md, line 304 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
UNIQUE`Link
Done.
releases/v20.2.0-alpha.1.md, line 307 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
vectorized engineLink
Done.
releases/v20.2.0-alpha.1.md, line 308 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach debug zip`Link
Done.
releases/v20.2.0-alpha.1.md, line 312 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`cockroach debug encryption-status`Link
Done.
releases/v20.2.0-alpha.1.md, line 317 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
DROP COLUMNLink
Done.
releases/v20.2.0-alpha.1.md, line 324 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`SHOW STATISTICS USING JSON`Link
Done.
releases/v20.2.0-alpha.1.md, line 325 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`ADD` or `RENAME` a columnLink
Done.
releases/v20.2.0-alpha.1.md, line 340 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
primary key change.Link
Done.
releases/v20.2.0-alpha.1.md, line 344 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
SHOW BACKUP SCHEMAS`Link
Done.
releases/v20.2.0-alpha.1.md, line 356 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`BYTES` typeLink
Done.
releases/v20.2.0-alpha.1.md, line 357 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Report engine type correctlyCockroachDB now correctly reports engine type
Done.
releases/v20.2.0-alpha.1.md, line 361 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Stop leaking fileCockroachDB no longer leaks file
Done.
releases/v20.2.0-alpha.1.md, line 373 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`BACKUP`Link
Done.
releases/v20.2.0-alpha.1.md, line 374 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
query optimizerLink
Updated here and elsewhere
releases/v20.2.0-alpha.1.md, line 376 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`UPDATE`Link
Done.
releases/v20.2.0-alpha.1.md, line 387 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`SHOW CREATE`Link
Done.
releases/v20.2.0-alpha.1.md, line 389 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Disable the Go runtime block profile by default which results inDisabled the Go runtime block profile by default, resulting in
Done.
releases/v20.2.0-alpha.1.md, line 394 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
`DROP TABLE`Link
Done.
releases/v20.2.0-alpha.1.md, line 396 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
Lookup joinsLink
Added links here and elsewhere
releases/v20.2.0-alpha.1.md, line 404 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
This problem was introduced early in the development for the 20.2 release, so should not have ever been part of a release.Should we remove this release note then?
I think we should keep it, since it is a bug fix.
ericharmeling
left a comment
There was a problem hiding this comment.
Awesome!
LGTM, with one more thing that I forget to mention: should there be updates to the following files as well?
- _config_base.yml (updated build date under 20.2)
- _data/releases.yml (release date listed under 20.2 release in "Testing releases")
Reviewed 1 of 1 files at r2.
Reviewable status:
I have no idea what this value should be. In the other big "add 20.2" PR, I think this was the same value. It appears to be a "magic value" that got put in but doesn't actually do anything?
OK! I will update this (and the date in the actual release note) once we get an official go/no-go on this release (which AFAICT we don't have yet). |
|
I think the 20.2 date in https://github.com/cockroachdb/docs/blob/master/_config_base.yml#L56 should just be manually update to match the release date. Those are used in some |
|
FYI - made a PR against the |
aab2568 to
3f18cb0
Compare
Fixes #7426
Depends on #7439