scripts: update release notes docker command#50113
Closed
rmloveland wants to merge 1 commit intocockroachdb:masterfrom
Closed
scripts: update release notes docker command#50113rmloveland wants to merge 1 commit intocockroachdb:masterfrom
rmloveland wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Previously, the `release-notes.py` script had logic to generate a `docker pull` command for release notes based on the current version of CockroachDB. However, this is not necessary because the docs website build process already has templating logic that builds the appropriate `docker pull` command by pulling the correct values from the file `cockroachdb/docs/_config_base.yml`. Therefore, this patch removes the script's logic that builds the `docker pull` command entirely, and replaces it with the templating syntax used by the docs website (which is just a string). Release note: None
Member
|
This change is |
Collaborator
Author
|
Closing since it turns out this doesn't actually work as I claimed above. The release notes page does not have access to the YAML information since it's in a different subdirectory. :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
release-notes.pyscript had logic to generate adocker pullcommand for release notes based on the current version ofCockroachDB.
However, this is not necessary because the docs website build process
already has templating logic that builds the appropriate
docker pullcommand by pulling the correct values from the file
cockroachdb/docs/_config_base.yml.Therefore, this patch removes the script's logic that builds the
docker pullcommand entirely, and replaces it with the templating syntax usedby the docs website (which is just a string).
Release note: None