Skip to content

Warn when calling RunTest on directory#18

Merged
nvb merged 1 commit intomasterfrom
nvanbenschoten/runDir
Feb 12, 2020
Merged

Warn when calling RunTest on directory#18
nvb merged 1 commit intomasterfrom
nvanbenschoten/runDir

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Feb 12, 2020

It's pretty easy to forget to use Walk and instead call RunTest directly
on a directory. This used to silently fail without running any tests. Now
it throws an error.


This change is Reviewable

It's pretty easy to forget to use Walk and instead call RunTest directly
on a directory. This used to silently fail without running any tests. Now
it throws an error.
@nvb nvb requested a review from tbg February 12, 2020 04:49
@nvb nvb merged commit aca0966 into master Feb 12, 2020
@nvb nvb deleted the nvanbenschoten/runDir branch February 12, 2020 14:27
nvb added a commit to nvb/cockroach that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants