changefeed: cancel jobs replicated from another cluster#99841
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 25, 2023
Merged
changefeed: cancel jobs replicated from another cluster#99841craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
miretskiy
approved these changes
Mar 30, 2023
Release note: none.
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
miretskiy
pushed a commit
to miretskiy/cockroach
that referenced
this pull request
Jul 7, 2023
Changefeeds created prior to cockroachdb#99841 do not have cluster ID field set in their job record. As a result, when upgrading to 23.1.x version, changefeeds created prior to that version will fail with an error message introduced by the above PR. Fix the cluster ID checking logic to handle this case. Release note (enterprise change): Changefeeds should no longer fail when upgrading to version 23.1.5.
miretskiy
pushed a commit
to miretskiy/cockroach
that referenced
this pull request
Jul 7, 2023
Changefeeds created prior to cockroachdb#99841 do not have cluster ID field set in their job record. As a result, when upgrading to 23.1.x version, changefeeds created prior to that version will fail with an error message introduced by the above PR. Fix the cluster ID checking logic to handle this case. Fixes cockroachdb#106358 Release note (enterprise change): Changefeeds should no longer fail when upgrading to version 23.1.5.
craig bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
106359: changefeedccl: Fix cluster ID check logic r=miretskiy a=miretskiy Changefeeds created prior to #99841 do not have cluster ID field set in their job record. As a result, when upgrading to 23.1.x version, changefeeds created prior to that version will fail with an error message introduced by the above PR. Fix the cluster ID checking logic to handle this case. Fixes #106358 Release note (enterprise change): Changefeeds should no longer fail when upgrading to version 23.1.5. Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
Changefeeds created prior to #99841 do not have cluster ID field set in their job record. As a result, when upgrading to 23.1.x version, changefeeds created prior to that version will fail with an error message introduced by the above PR. Fix the cluster ID checking logic to handle this case. Fixes #106358 Release note (enterprise change): Changefeeds should no longer fail when upgrading to version 23.1.5.
maryliag
pushed a commit
that referenced
this pull request
Jul 24, 2023
Changefeeds created prior to #99841 do not have cluster ID field set in their job record. As a result, when upgrading to 23.1.x version, changefeeds created prior to that version will fail with an error message introduced by the above PR. Fix the cluster ID checking logic to handle this case. Fixes #106358 Release note (enterprise change): Changefeeds should no longer fail when upgrading to version 23.1.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: none.
Epic: CRDB-18753