catalog: remove the chart catalog#99788
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 25, 2023
Merged
Conversation
Member
|
This change is |
c0f4440 to
ccb5863
Compare
3b2926d to
ec0d660
Compare
Member
Author
|
@dhartunian I think this could be reviewed and merged, I can file an issue about the customcharts endpoint since I won't be able to deal with it anyway. I'm going to rebase if you agree that now's a good time to push this over the line. |
dhartunian
approved these changes
Apr 21, 2023
Collaborator
dhartunian
left a comment
There was a problem hiding this comment.
@tbg customcharts is completely unused and can be removed separately. yeah we should probably go through a bit of ceremony if it is part of our v1 api.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
- tsdump: simplify code a bit - tsdump: query AllMetricMetadata endpoint to get all timeseries names (rather than filling it server-side in the TSDB, which doesn't really have access to it now) - tsdump: return error instead of filling in metric names - serverpb: add GetInternalTimeSeriesNamesFromServer, this is code that essentially lived in `catalog`, but with some cleanups. We need this to go from "metric name" to "actual name the TSDB stores this under in KV" because that's what `tsdump` operates on. - catalog: return a flat mock stub in GenerateCatalog - catalog: pretty much delete everything else, including that list of metrics that needed to be manually adjusted every time a metric was added or removed. A 23.1 cli will fail to fetch the timeseries from a 23.2+ host, but the error message is informative and I don't think additional complexity to smoothen mixed-version deploys is warranted. A 23.2+ cli will work fine with older releases. Tidy up a few issues that had to do with auto-generating Grafana dashboards from the catalog: Closes cockroachdb#54178. Closes cockroachdb#78232. Closes cockroachdb#81035. Epic: none Release note: None
ec0d660 to
3c5c368
Compare
Member
Author
|
bors r=dhartunian |
Contributor
|
Build failed: |
Member
Author
|
bors r=dhartunian |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roughly the following, all in the same commit (sorry - discovered what needed to be done as I went, if reviewers find it hard to grok I can try to chop it into commits):
(rather than filling it server-side in the TSDB, which doesn't
really have access to it now)
essentially lived in
catalog, but with some cleanups.We need this to go from "metric name" to "actual name the TSDB stores this
under in KV" because that's what
tsdumpoperates on.list of metrics that needed to be manually adjusted every time
a metric was added or removed.
A 23.1 cli will fail to fetch the timeseries from a 23.2+ host, but the error
message is informative and I don't think additional complexity to smoothen
mixed-version deploys is warranted. A 23.2+ cli will work fine with older
releases.
Closes #99791.
Tidy up a few issues that had to do with auto-generating Grafana dashboards
from the catalog:
Closes #54178.
Closes #78232.
Closes #81035.
Epic: none
Release note: None