sqlsmith: add DEFAULT expressions to newly added columns#99312
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 31, 2023
Merged
sqlsmith: add DEFAULT expressions to newly added columns#99312craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
d425c87 to
34dfb73
Compare
rharding6373
approved these changes
Mar 22, 2023
Collaborator
rharding6373
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build failed: |
Contributor
Author
|
Looks like a flake. bors r+ |
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Required status check \"Bazel Essential CI (Cockroach)\" is pending.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sqlsmith now builds `ALTER TABLE .. ADD COLUMN .. DEFAULT` statements with default expressions that have different types than the column type. This is allowed if the default expression type can be assignment-casted to the column's type. Fixes cockroachdb#98133 Release note: None
34dfb73 to
b966677
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sqlsmith now builds
ALTER TABLE .. ADD COLUMN .. DEFAULTstatementswith default expressions that have different types than the column type.
This is allowed if the default expression type can be assignment-casted
to the column's type.
Fixes #98133
Release note: None