-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sqlsmith/randgen: generate DEFAULT expressions that don't match the column's type #98133
Copy link
Copy link
Closed
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)E-quick-winLikely to be a quick win for someone experienced.Likely to be a quick win for someone experienced.O-postmortemOriginated from a Postmortem action item.Originated from a Postmortem action item.T-sql-queriesSQL Queries TeamSQL Queries Team
Description
SQLSmith/randgen only generate DEFAULT expressions that match a column's type exactly. Therefore, our randomized tests don't exercise logic in #81071 that allows creating a DEFAULT expression of type A for coluymn of type B if a cast from A to B is allowed in the assignment context.
When generating DEFAULT expressions, we should randomly pick a type for the expression that can be assignment-cast into the column's type.
Jira issue: CRDB-25097
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)E-quick-winLikely to be a quick win for someone experienced.Likely to be a quick win for someone experienced.O-postmortemOriginated from a Postmortem action item.Originated from a Postmortem action item.T-sql-queriesSQL Queries TeamSQL Queries Team
Type
Projects
Status
Done