statusccl: stop serving /_status/nodes to tenants#98398
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 14, 2023
matthewtodd:remove-tenant-nodes
Merged
statusccl: stop serving /_status/nodes to tenants#98398craig[bot] merged 1 commit intocockroachdb:masterfrom matthewtodd:remove-tenant-nodes
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:remove-tenant-nodes
Conversation
Member
|
This change is |
maryliag
approved these changes
Mar 14, 2023
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @matthewtodd)
Author
|
Test failure is #98213, re-running. |
Collaborator
|
@matthewtodd I've got a PR in flight that should resolve the flake: #47121 |
Author
|
Waiting on #98410 before landing this. |
Author
|
bors r+ |
1 similar comment
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98057.
This reverts the work of #93268, which is no longer necessary now that we are eagerly capturing region information at execution time in #95449.
Release note: None