cluster-ui: tenants use sqlstats-supplied regions#98410
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 14, 2023
matthewtodd:sqlstats-regions
Merged
cluster-ui: tenants use sqlstats-supplied regions#98410craig[bot] merged 1 commit intocockroachdb:masterfrom matthewtodd:sqlstats-regions
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:sqlstats-regions
Conversation
Member
|
This change is |
Fixes #98056. As of #95449, the SQL Activity pages in the DB Console can draw regions information directly from the sqlstats tables, rather than having to translate node IDs to regions on page load. Here, we make that switch, but for non-system tenants only, because: 1. The ephemeral nature of serverless nodes made this view-time mapping especially problematic in that context. (See further notes in #95449.) 2. The system-tenant views also include KV node IDs in a special Regions/Nodes column, which we are unable to recreate given the backend storage structure. (Future design work might suggest removing these node IDs altogether, for a unified UI.) Release note: None
Author
|
@maryliag we'll want to coordinate when to put this into a cluster-ui release. |
maryliag
reviewed
Mar 14, 2023
Contributor
maryliag
left a comment
There was a problem hiding this comment.
we'll want to coordinate when to put this into a cluster-ui release.
what is the concern of what should be added together?
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)
maryliag
approved these changes
Mar 14, 2023
Author
|
Thanks, @maryliag! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98056.
As of #95449, the SQL Activity pages in the DB Console can draw regions information directly from the sqlstats tables, rather than having to translate node IDs to regions on page load.
Here, we make that switch, but for non-system tenants only, because:
The ephemeral nature of serverless nodes made this view-time mapping especially problematic in that context. (See further notes in sqlstats: include regions in statement_statistics #95449.)
The system-tenant views also include KV node IDs in a special Regions/Nodes column, which we are unable to recreate given the backend storage structure. (Future design work might suggest removing these node IDs altogether, for a unified UI.)
Screenshots!
Statements, with and without regions filter
Statement details
Transactions, with and without regions filter
Transaction details
Release note: None