status: set codec from context in table stats requests#97511
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 1, 2023
Merged
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
knz
approved these changes
Feb 22, 2023
Contributor
knz
left a comment
There was a problem hiding this comment.
This is great! But it also needs a test.
arulajmani
approved these changes
Feb 22, 2023
4661cca to
f60e751
Compare
Replaced usages of `TODOSQLCodec` with the codec from `sqlServer.execCfg`. This enables the DB and Table stats endpoints to work from tenants. Resolves: cockroachdb#82879 Relates to: cockroachdb#90261, cockroachdb#90267, cockroachdb#90268, cockroachdb#90264, cockroachdb#89429 Epic: CRDB-12100 Release note: None
f60e751 to
4308e91
Compare
Collaborator
Author
|
bors r=knz |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced usages of
TODOSQLCodecwith the codec fromsqlServer.execCfg. This enables the DB and Table stats endpoints to work from tenants.Resolves: #82879
Relates to: #90261, #90267, #90268, #90264, #89429
Epic: CRDB-12100
Release note: None