-
Notifications
You must be signed in to change notification settings - Fork 4.1k
server: make TableDetails endpoint tenant-scoped #90264
Description
Is your feature request related to a problem? Please describe.
Part of: #89429
Blockers: #82879, #90267
As part of our effort to migrate to a multi-tenant architecture, we need to ensure our existing table details endpoint is tenant-scoped.
Unfortunately, the TableDetails endpoint makes use of two functions that block our ability to scope to tenants:
generateTableScan:generateTableScandoes not decode with the proper tenant prefix, instead usingTODOSQLCodec. There is an issue filed for this already: server: the TableDetails, TableStats, DatabaseDetails API don't decode with a proper tenant prefix #82879, which will need to be resolved to unblock this issue.CountRanges:CountRangesmakes use of the KV layer which tenants will not have access to, there is an issue filed for this already: server: tenant span stats for TableStats, TableDetails & DatabaseDetails endpoints #90267 which will need to be resolved to unblock this issue.
To maintain all information we provide currently, the blockers above would need to be resolved to allow the endpoint to be tenant-scoped.
Alternatively, If we choose to initially omit the RangeCount statistics from the TableDetails endpoint:
Line 1058 in 669e9a5
| resp.RangeCount = rangeCount |
we can immediately work on tenant-scoping the endpoint, with the idea to resolve the blockers above and add RangeCount in the future.
Jira issue: CRDB-20664
Epic CRDB-16704