roachtest: verbose gRPC logging for admission-control/tpcc-olap#96782
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 8, 2023
Merged
roachtest: verbose gRPC logging for admission-control/tpcc-olap#96782craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
I ran the test[^1] and it passed, so hopefully this isn't obviously breaking anything. See cockroachdb#96543. [^1]: `GCE_PROJECT=andrei-jepsen ./pkg/cmd/roachtest/roachstress.sh -c 1 -u admission-control/tpcc-olap/nodes=3/cpu=8/w=50/c=96 -- tag:weekly` Epic: none Release note: None
irfansharif
approved these changes
Feb 8, 2023
Member
Author
|
bors r=irfansharif |
Contributor
|
Build succeeded: |
katmayb
pushed a commit
to katmayb/cockroach
that referenced
this pull request
Feb 9, 2023
96768: server: remove stale comment r=andreimatei a=andreimatei Release note: None Epic: None 96781: rpc: improve detection of onlyOnceDialer redials r=erikgrinaker a=tbg While looking into cockroachdb#96543, I wasn't 100% sure we weren't accidentally redialing a connection internally. This improved logging and the test makes it more obvious that things are working as intended. Touches cockroachdb#96543. Epic: none Release note: None 96782: roachtest: verbose gRPC logging for admission-control/tpcc-olap r=irfansharif a=tbg Closes cockroachdb#96543. Next time we'll know more. Epic: none Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96543.
Next time we'll know more.
Epic: none
Release note: None