roachpb: treat DeprecatedVerifyChecksumRequest as NoopRequest#9362
Merged
tamird merged 2 commits intocockroachdb:masterfrom Sep 14, 2016
tamird:deprecated-request
Merged
roachpb: treat DeprecatedVerifyChecksumRequest as NoopRequest#9362tamird merged 2 commits intocockroachdb:masterfrom tamird:deprecated-request
tamird merged 2 commits intocockroachdb:masterfrom
tamird:deprecated-request
Conversation
Collaborator
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
Contributor
Author
|
Updated to return a response with the right tag number and added a smoke test. |
Member
|
LGTM |
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Dec 3, 2016
Restore the header fields to deprecated requests and responses instead of embedding a NoopRequest (partially reverting cockroachdb#9362). NoopRequests do not have keys, but never appear alone, ensuring that the batch as a whole has at least one request with keys. Deprecated requests, however, can appear alone and therefore must have keys to allow other invariants to be validated.
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Dec 4, 2016
Restore the header fields to deprecated requests and responses instead of embedding a NoopRequest (partially reverting cockroachdb#9362). NoopRequests do not have keys, but never appear alone, ensuring that the batch as a whole has at least one request with keys. Deprecated requests, however, can appear alone and therefore must have keys to allow other invariants to be validated.
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Dec 6, 2016
Restore the header fields to deprecated requests and responses instead of embedding a NoopRequest (partially reverting cockroachdb#9362). NoopRequests do not have keys, but never appear alone, ensuring that the batch as a whole has at least one request with keys. Deprecated requests, however, can appear alone and therefore must have keys to allow other invariants to be validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9347
@mberhault @cockroachdb/stability
This change is