Skip to content

wip#93265

Closed
tbg wants to merge 1 commit intocockroachdb:masterfrom
tbg:apply-refactor-attempt-2
Closed

wip#93265
tbg wants to merge 1 commit intocockroachdb:masterfrom
tbg:apply-refactor-attempt-2

Conversation

@tbg
Copy link
Copy Markdown
Member

@tbg tbg commented Dec 8, 2022

No description provided.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@tbg
Copy link
Copy Markdown
Member Author

tbg commented Dec 8, 2022

Just wanted a stable link to this.

@tbg tbg closed this Dec 8, 2022
craig bot pushed a commit that referenced this pull request Dec 21, 2022
93266: kvserver: refactor replicaAppBatch for standalone log application r=pavelkalinnikov a=tbg

This long (but individually small) sequence of commits moves `(*replicaAppBatch).Stage` close to the structure that was prototyped in #93265, where it has the following steps:

- command checks (standalone)
- testing interceptors (replica)
- pre-add triggers (standalone)
- pre-add triggers (replica)
- add (to pebble batch, standalone)
- post-add triggers (standalone)
- post-add triggers (replica)

In standalone application (e.g. for #93244) we'd use an `apply.Batch` that is an `appBatch`, instead of a `replicaAppBatch`, i.e. skip all of the (replica) steps above.

This PR doesn't get us all the way there - we still need to tease apart the `post-add triggers (replica)` step, which currently contains code that should be in `post-add triggers (standalone)`; this is best tackled in a separate PR since it's going to be quite a bit of work.

Touches #75729.

Epic: CRDB-220
Release note: None

Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants