kvserver: remove the assertion on not exceeding MaxSpanRequestKeys#92942
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 2, 2022
Merged
kvserver: remove the assertion on not exceeding MaxSpanRequestKeys#92942craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Member
Author
|
Well, a "simple" change in #92883 was buggy, so let's remove the assertion like you were suggesting :) |
This commit fixes the bug in a recently merged commit where we allowed to exceed `MaxSpanRequestKeys` in some cases - we forgot to update the remaining limit to be "exhausted". Furthermore, this commit removes the assertion altogether. Epic: None Release note: None
31243fd to
002c75e
Compare
erikgrinaker
approved these changes
Dec 2, 2022
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug in a recently merged commit where we allowed to exceed
MaxSpanRequestKeysin some cases - we forgot to update the remaining limit to be "exhausted". Furthermore, this commit removes the assertion altogether.Epic: None
Release note: None