kvserver: allow exceeding MaxSpanRequestKeys limit in some cases#92883
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 2, 2022
Merged
kvserver: allow exceeding MaxSpanRequestKeys limit in some cases#92883craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit removes an assertion that `MaxSpanRequestKeys` is not exceeded. In particular, this limit can be exceeded when SQL asks for full SQL rows (by specifying non-zero `WholeRowsOfSize`) and doesn't allow for empty responses (by specifying `AllowEmpty` as `false`). Note that this code path hasn't been hit so far in production because the only user of `WholeRowsOfSize` (the streamer) currently doesn't set `MaxSpanRequestKeys`. Release note: None
Member
|
This change is |
erikgrinaker
approved these changes
Dec 2, 2022
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Thanks! I would be ok with just removing the assertion outright as well, but this works.
Member
Author
|
The assertion seems somewhat useful to me, so let's keep it for now. TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes an assertion that
MaxSpanRequestKeysis not exceeded. In particular, this limit can be exceeded when SQL asks for full SQL rows (by specifying non-zeroWholeRowsOfSize) and doesn't allow for empty responses (by specifyingAllowEmptyasfalse). Note that this code path hasn't been hit so far in production because the only user ofWholeRowsOfSize(the streamer) currently doesn't setMaxSpanRequestKeys.Informs: #82323.
Release note: None