multiregionccl: add a cold start latency test #92826
Merged
craig[bot] merged 4 commits intocockroachdb:masterfrom Jan 20, 2023
Merged
multiregionccl: add a cold start latency test #92826craig[bot] merged 4 commits intocockroachdb:masterfrom
craig[bot] merged 4 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
3085659 to
0f33e97
Compare
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Dec 9, 2022
This is an oversight from cockroachdb#92588. Testing will come in cockroachdb#92826. Epic: CRDB-18596 Release note: None
972c163 to
d3874fb
Compare
craig bot
pushed a commit
that referenced
this pull request
Dec 10, 2022
93294: dev: do not log noisy bep flag r=rickystewart a=healthy-pod Release note: None Epic: none 93342: sql: partition lease table when optimizing system database for MR r=ajwerner a=ajwerner This is an oversight from #92588. Testing will come in #92826. Epic: CRDB-18596 Release note: None Co-authored-by: healthy-pod <ahmad@cockroachlabs.com> Co-authored-by: Ahmad Abedalqader <ahmad@cockroachlabs.com> Co-authored-by: Andrew Werner <awerner32@gmail.com>
d3874fb to
f70079a
Compare
fqazi
approved these changes
Jan 19, 2023
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jeffswenson)
Release note: None
Release note: None
Release note: None
f70079a to
e926308
Compare
jeffswenson
approved these changes
Jan 20, 2023
| ) | ||
| localities := makeLocalities(regionLatencies, numNodes, numAZsPerRegion) | ||
| regions := make([]string, len(localities)) | ||
| { |
Collaborator
There was a problem hiding this comment.
nit: is the extra block wrapping l.Find intentional?
| t.Log("pre running test to allocate instance IDs") | ||
| t.Log("result", localities, runAllTests()) | ||
| t.Log("running test with no connectivity from sql pods to remote regions") | ||
| blockCrossRegionTenantAccess.Store(true) |
Collaborator
There was a problem hiding this comment.
Blocking cross-region network traffic is a neat check.
e926308 to
e3e4bdc
Compare
This commit adds a test which creates an MR serverless cluster and then boots the sql pods in each region while disallowing connectivity to other regions. It also simulates latency to make sure the routing logic works and to provide a somewhat realistic picture of what to expect. Release note: None
e3e4bdc to
4c59d79
Compare
ajwerner
commented
Jan 20, 2023
Contributor
Author
ajwerner
left a comment
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/ccl/multiregionccl/cold_start_latency_test.go line 71 at r8 (raw file):
Previously, JeffSwenson (Jeff Swenson) wrote…
nit: is the extra block wrapping l.Find intentional?
Done.
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a test which creates an MR serverless cluster and then
boots the sql pods in each region while disallowing connectivity to other
regions. It also simulates latency to make sure the routing logic works
and to provide a somewhat realistic picture of what to expect.
Epic: CRDB-18596
Release note: None