This change is 

So it looks like we still have work to do here. We either want to remove all uses of io/ioutil or find a way that let's us ignore excluded uses like what we do in testutil. [context]

@healthy-pod

In pkg/security/securitytest/embedded.go and pkg/roachprod/vm/aws/embedded.go you have a call to ioutil.WriteFile. This can just be replaced by os.WriteFile. For the other uses of ioutil.ReadDir, one thing we can do is enumerate the existing uses, file bugs, and assign them to appropriate owners so they can be fixed by someone who knows what they're doing.

Uses of ReadDir:

pkg/roachprod/install/cluster_synced.go
pkg/security/securityassets/security_assets.go
pkg/security/securitytest/securitytest.go
pkg/server/dumpstore/dumpstore.go
pkg/server/dumpstore/dumpstore_test.go
pkg/server/heapprofiler/profilestore_test.go
pkg/util/log/file_api.go

Possible some of these can be easily fixed too. You can exclude these files in exclude_files for the analyzer in build/bazelutil/nogo_config.json.

Alright it's looking good now TFTR!

I also opened the following issues to alert teams: #92864 #92862 #92861

bors r=rickystewart

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

Build succeeded:

• Bazel Essential CI (Cockroach)