Skip to content

bazel: nogo does not seem to catch all deprecation errors #84877

@rickystewart

Description

@rickystewart

Found in TC run for #84590 at a8c77d7ad18cadba1310c04e526cd845e2a090c6:

        pkg/util/netutil/net.go:140:52: ne.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method.  (SA1019)
    lint_test.go:1765:
        pkg/util/netutil/net.go:173:11: netError.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method.  (SA1019)

nogo did not raise this.

Epic CRDB-8349

Jira issue: CRDB-17922

Metadata

Metadata

Assignees

Labels

A-build-systemC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-dev-inf

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions