sql: Fix syntax error when inserting into system.table_statistics#92419
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 29, 2022
Merged
Conversation
Member
|
This change is |
b7ba3a7 to
cb8faaf
Compare
michae2
approved these changes
Nov 23, 2022
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner, @renatolabs, and @rytaft)
rytaft
approved these changes
Nov 23, 2022
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
Contributor
Author
|
TFTR! 🎉 bors r=rytaft |
Contributor
|
Build failed: |
Contributor
Author
|
bors r=rytaft |
Contributor
|
Build failed: |
Previously, code that was run if the clusterversion `V23_1AddPartialStatisticsPredicateCol` was not active would return a syntax error due to a superflous comma in an INSERT SQL statement in a roachtest. Release note: None
cb8faaf to
2a5e783
Compare
Contributor
Author
|
bors r=rytaft |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, code that was run if the clusterversion
V23_1AddPartialStatisticsPredicateColwas not active would return a syntax error due to a superfluous comma in an INSERT SQL statement in a roachtest.Release note: None
Resolves: #92412