-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql/stats: syntax error when inserting into system.table_statistics #92412
Copy link
Copy link
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-queriesSQL Queries TeamSQL Queries Team
Description
Describe the problem
The following syntax error was observed in the cdc/mixed-versions roachtest (#92371):
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 AUTO CREATE STATS job 816309460189839363: stepping through state reverting with error: ‹insert-statistic›: at or near "‹)›": ‹syntax error›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +(1) attached stack trace
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + -- stack trace:
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).execInternal.func1
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/internal.go:839
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).execInternal
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/internal.go:859
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).ExecEx
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/internal.go:684
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).Exec
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/internal.go:665
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/stats.InsertNewStat
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/stats/pkg/sql/stats/new_stat.go:96
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/rowexec.(*sampleAggregator).writeResults.func1
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/rowexec/sample_aggregator.go:509
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.runTxn.func1
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/db.go:960
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.(*Txn).exec
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/txn.go:926
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.runTxn
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/db.go:959
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.(*DB).TxnWithAdmissionControl
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/db.go:922
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.(*DB).Txn
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/db.go:901
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/rowexec.(*sampleAggregator).writeResults
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/rowexec/sample_aggregator.go:436
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/rowexec.(*sampleAggregator).mainLoop
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/rowexec/sample_aggregator.go:340
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/rowexec.(*sampleAggregator).Run
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/rowexec/sample_aggregator.go:195
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/flowinfra.(*FlowBase).Run
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/flowinfra/flow.go:481
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).Run
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:813
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).planAndRunCreateStats
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/distsql_plan_stats.go:504
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql.(*createStatsResumer).Resume.func1
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/create_stats.go:626
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.runTxn.func1
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/db.go:960
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.(*Txn).exec
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/txn.go:926
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.runTxn
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/db.go:959
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.(*DB).TxnWithAdmissionControl
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/db.go:922
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv.(*DB).Txn
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/kv/db.go:901
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql.(*createStatsResumer).Resume
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/sql/create_stats.go:608
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine.func2
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1297
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/jobs/registry.go:1298
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/jobs/adopt.go:412
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/jobs.(*StartableJob).Start.func2
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/jobs/jobs.go:913
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 + | github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:489
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +Wraps: (2) ‹insert-statistic›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +Wraps: (3) ‹try \h <SELECTCLAUSE>›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +Wraps: (4) ‹source SQL:›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | INSERT INTO system.table_statistics (›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | "tableID",›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | "name",›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | "columnIDs",›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | "rowCount",›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | "distinctCount",›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | "nullCount",›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | "avgSize",›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | histogram,›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | ) VALUES ($1, $2, $3, $4, $5, $6, $7, $8)›
I221123 07:24:37.312692 42885 jobs/registry.go:1255 ⋮ [n3] 143 +‹ | ^›
Jira issue: CRDB-21752
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-queriesSQL Queries TeamSQL Queries Team
Type
Projects
Status
Done