Skip to content

storage: add MVCCExportFingerprintOptions#91719

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
stevendanna:fingerprint-strip-tenant-prefix
Nov 15, 2022
Merged

storage: add MVCCExportFingerprintOptions#91719
craig[bot] merged 1 commit intocockroachdb:masterfrom
stevendanna:fingerprint-strip-tenant-prefix

Conversation

@stevendanna
Copy link
Copy Markdown
Collaborator

This adds MVCCExportFingerprintOptions with two new options:

  • StripTenantPrefix
  • StripValueChecksum

The goal of these options is to produce a fingerprint that can be used for comparing data across two tenants.

Note that if arbitrary keys and values are encountered, both options have the possibility of erroneously removing data from the fingerprint that isn't actually a tenant prefix or checksum.

Fixes #91150

Release note: None

This adds MVCCExportFingerprintOptions with two new options:

 - StripTenantPrefix
 - StripValueChecksum

The goal of these options is to produce a fingerprint that can be used
for comparing data across two tenants.

Note that if arbitrary keys and values are encountered, both options
have the possibility of erroneously removing data from the fingerprint
that isn't actually a tenant prefix or checksum.

Fixes cockroachdb#91150

Release note: None
@stevendanna stevendanna requested a review from a team as a code owner November 11, 2022 01:10
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stevendanna
Copy link
Copy Markdown
Collaborator Author

bors r=adityamaru

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 14, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 15, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 15, 2022

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

@stevendanna
Copy link
Copy Markdown
Collaborator Author

bors r+

@craig craig bot merged commit 03f6062 into cockroachdb:master Nov 15, 2022
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 15, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

batcheval: add option to trim tenant prefix and value metadata before fingerprinting

3 participants