sql: turn plan sampling back on by default#89020
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 29, 2022
Merged
sql: turn plan sampling back on by default#89020craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This value was disabled by default on cockroachdb#88343 but brought visibility to a bug of statements not being properly trace when they should be on the first time. Since we might not be able to finish the proper fix before the cut on backports, I'm turning back on and a following commit can turn this back off and add the fix for the problem. Release note (sql change): Turn the default value of `sql.metrics.statement_details.plan_collection.enabled` to `true`
Member
|
This change is |
xinhaoz
approved these changes
Sep 29, 2022
Contributor
xinhaoz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
Contributor
Author
|
bors r+ |
Contributor
|
Build failed: |
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
89782: roachtest: limit FingerprintValidator's memory usage internally r=miretskiy,srosenberg a=renatolabs In #89332, we started optionally validating changefeed semantics in the `FingerprintValidator` by making sure that unseen updates are never observed if a `resolved` message is received. In order to keep bounds on the validator's memory usage, the `cdc/mixed-versions` test was setting a maximum number of operations at the workload level. However, a consequence of that change is that it creates the possibility for the workload to finish before the roachtest has received all the `resolved` events it expects (for instance, if draining takes longer than usual for some reason; a variety of other non-determinism is also at play). To deal with this possibility, we instead enforce a maximum number of previously seen events at the validator's level. For the `cdc/mixed-versions` test, we set a maximum of 100,000 previously seen events being stored (20MB memory footprint). This should be equivalent to roughly 50,000 bank transfers, and give enough time for the test to finish successfully. Release note: None Epic: None. 89847: sql: turn plan sampling back off by default r=j82w a=j82w The value was originally disabled by default in: #88343. The value was enabled by default: #89020 because of a bug that was fixed in #89418. This PR is disabling it by default again now that the bug has been fixed. Part Of #89847 Release note (sql change): Turn the default value of sql.metrics.statement_details.plan_collection.enabled to false. Co-authored-by: Renato Costa <renato@cockroachlabs.com> Co-authored-by: j82w <jwilley@cockroachlabs.com>
j82w
pushed a commit
that referenced
this pull request
Oct 18, 2022
This value was enabled by default again: #89020. The reason it was enabled again was fixed in #89418. Part of #89847 Release justification: Bug fixes and low-risk updates to new functionality. Release note (sql change): Turn the default value of sql.metrics.statement_details.plan_collection.enabled to false.
j82w
pushed a commit
that referenced
this pull request
Nov 2, 2022
This value was enabled by default again: #89020. The reason it was enabled again was fixed in #89418. Part of #89847 Release justification: Bug fixes and low-risk updates to new functionality. Release note (sql change): Turn the default value of sql.metrics.statement_details.plan_collection.enabled to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This value was disabled by default on #88343
but brought visibility to a bug of statements not being properly trace when they should be on the first time. Since we might not be able to finish the proper fix before the cut on backports, I'm turning back on and a following commit can turn this back off and add the fix for the problem.
Release note (sql change): Turn the default value of
sql.metrics.statement_details.plan_collection.enabledtotrue