scheduledlogging: various fixes to index stat collection#87773
scheduledlogging: various fixes to index stat collection#87773craig[bot] merged 7 commits intocockroachdb:masterfrom
Conversation
Release note: None
The change in 4f632e1 was missing its regression tests (there were no indexes created). This patch fixes it and also simplifies the test code. Release note: None
The setting classes for `sql.telemetry.capture_index_usage_stats.interval`, `sql.telemetry.capture_index_usage_stats.check_enabled_interval`, `sql.telemetry.capture_index_usage_stats.logging_delay` were incorrect. Since the telemetry is running in every tenant, the tenants need to be able to query the value of the setting. (We are not allowing the tenants to write to them as we don't want them to influence the volume of telemetry.) Release note: None
Release note: None
This test was failing under stress because it wasn't able to tolerate a 1-second rounding difference between actual and expected intervals. This commit fixes it. Release note: None
|
This change is |
|
Please also indicate if this needs to be backported to 22.1 |
This test takes between 1 and 2 minutes to run. (cockroachdb#87772) Release note: None
The idiomatic go way to handle timers is to `Close` them in a `defer`. This patch does this. Additionally, the index stat collection could enter into a tight loop when certain cluster settings are set to zero. This patch removes that edge case. Release note: None
7fab9b9 to
a41310d
Compare
xinhaoz
left a comment
There was a problem hiding this comment.
Additional test cases
Reviewed 1 of 2 files at r6, 1 of 1 files at r7.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @THardy98)
|
So what do you think about backports? |
|
bors r=xinhaoz |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 0ec06d7 to blathers/backport-release-22.2-87773: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
With #88999 backported to 22.1, we can probably backport this to 22.1 as well (also, super sorry for not seeing this earlier). |
As I was reviewing #87525, I noticed that the actual test cases were missing.
Then, as I tried to fix that, I discovered a couple of other shortcomings. This PR fixes them.
Fixes #87771.
Informs #87772.