Skip to content

release-22.1: sql: fix recording db names with hyphen for idx usage stats#88999

Merged
THardy98 merged 1 commit intocockroachdb:release-22.1from
THardy98:backport22.1-87525
Sep 29, 2022
Merged

release-22.1: sql: fix recording db names with hyphen for idx usage stats#88999
THardy98 merged 1 commit intocockroachdb:release-22.1from
THardy98:backport22.1-87525

Conversation

@THardy98
Copy link
Copy Markdown

@THardy98 THardy98 commented Sep 29, 2022

Backport 1/1 commits from #87525.

/cc @cockroachdb/release

Fixes #85577

This commit fixes a bug where the query constructed during
index usage stats recording failed for db names containing
a hyphen. The db name placeholder is now converted to string
from the tree.Name, which should properly escape hyphen
characters for the query.

Release justification: bug fix

Release note (bug fix): index usage stats are properly captured for database names with hyphens

@xinhaoz
sql: fix recording db names with hyphen for idx usage stats
3215460 
Fixes cockroachdb#85577

This commit fixes a bug where the query constructed during
index usage stats recording failed for db names containing
a hyphen. The db name placeholder is now converted to string
from the `tree.Name`, which should properly escape hyphen
characters for the query.

Release justification: bug fix

Release note (bug fix): index usage stats are properly captured
for database names with hyphens
@THardy98 THardy98 requested a review from maryliag September 29, 2022 14:50
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Sep 29, 2022 •
edited by THardy98
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Sep 29, 2022

This change is Reviewable

maryliag
maryliag approved these changes Sep 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as tests are passing :lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@THardy98 THardy98 merged commit f9944d4 into cockroachdb:release-22.1 Sep 29, 2022
@THardy98 THardy98 mentioned this pull request Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maryliag maryliag maryliag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@THardy98 @cockroach-teamcity @maryliag @xinhaoz