Skip to content

builtins: hide crdb_internal.probe_ranges from docs#87318

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-probe-docs
Sep 7, 2022
Merged

builtins: hide crdb_internal.probe_ranges from docs#87318
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-probe-docs

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Sep 1, 2022

fixes #84758

Release note: None

Release justification: docs only change

@rafiss rafiss requested review from a team and Santamaura September 1, 2022 23:42
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Sep 1, 2022

i will backport to 21.2 if #84292 gets merged

Copy link
Copy Markdown
Contributor

@Santamaura Santamaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: once CI passes

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

Release note: None

Release justifiaction: docs only change

Release justification:
Copy link
Copy Markdown
Contributor

@e-mbrown e-mbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @rafiss)

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Sep 7, 2022

tftr!

bors r+

@craig craig bot merged commit 76a5f63 into cockroachdb:master Sep 7, 2022
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 7, 2022

Build succeeded:

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Sep 7, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 7aacb53 to blathers/backport-release-22.1-87318: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix style of crdb_internal.probe_ranges generated function documentation

4 participants