Skip to content

release-21.2: [CRDB-2743] sql: create builltin generator crdb_internal.probe_range#84292

Closed
Santamaura wants to merge 1 commit intocockroachdb:release-21.2from
Santamaura:backport21.2-79546
Closed

release-21.2: [CRDB-2743] sql: create builltin generator crdb_internal.probe_range#84292
Santamaura wants to merge 1 commit intocockroachdb:release-21.2from
Santamaura:backport21.2-79546

Conversation

@Santamaura
Copy link
Copy Markdown
Contributor

@Santamaura Santamaura commented Jul 12, 2022 •
edited
Loading

Backport 1/1 commits from #79546.

/cc @cockroachdb/release

Previously there was difficulty in diagnosing kv layer health when
an incident occurs. This patch introduces the new virtual table
crdb_internal.probe_range which utilizes the kvprober to probe
each range to determine if the range can be reached or not.

resolves #61695

Release note: None

Screen Shot 2022-04-20 at 1 15 17 PM

Release justification: Observability QoL improvement

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jul 12, 2022 •
edited by Santamaura
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jul 12, 2022

This change is Reviewable

@Santamaura Santamaura marked this pull request as ready for review July 12, 2022 17:44
@Santamaura Santamaura requested a review from a team as a code owner July 12, 2022 17:44
@Santamaura Santamaura force-pushed the backport21.2-79546 branch from ff42d68 to 2b3f828 Compare July 13, 2022 14:12
@rafiss
Copy link
Copy Markdown
Collaborator

rafiss commented Sep 1, 2022

@Santamaura do you plan to merge this, or have you decided to hold off?

@rafiss rafiss mentioned this pull request Sep 1, 2022
Merged
@Santamaura
sql: create builtin generator crdb_internal.probe_ranges
9895968 
Previously there was difficulty diagnosing kv layer health
when an incident occurs. This patch introduces a new virtual
table crdb_internal.probe_ranges which utilitzes the kvprober
probe each range to determine if the range can be reached or
not.

resolves cockroachdb#61695

Release note: None
@Santamaura
Copy link
Copy Markdown
Contributor Author

Santamaura commented Sep 2, 2022

@rafiss this one is blocked from merging as there are some indirect changes to EvalContext and Span that haven't been back-ported (haven't gotten around to finding someone to back-port those changes/make the changes myself)

@rafiss
Copy link
Copy Markdown
Collaborator

rafiss commented Sep 6, 2022

Thanks! Given that it's been this long and 21.2 will have no more releases after November, it doesn't feel that urgent to get this in.

@stevendanna
Copy link
Copy Markdown
Collaborator

stevendanna commented Oct 9, 2025

Closing this PR as release-21.2 is a branch for an unsupported version. If you believe this was in error, please feel free to re-open.

@stevendanna stevendanna closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbg tbg tbg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Santamaura @cockroach-teamcity @rafiss @stevendanna @tbg