github-post: allow for finding the test in a parent directory of the pkg#87155
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 31, 2022
Merged
github-post: allow for finding the test in a parent directory of the pkg#87155craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
srosenberg
reviewed
Aug 31, 2022
srosenberg
approved these changes
Aug 31, 2022
rail
approved these changes
Aug 31, 2022
In some cases the Bazel test runner "incorrectly" reports the package path for tests. For example, we have [issues](cockroachdb#85376) where the name of the test is reported as `pkg/.../package/package_test` rather than `pkg/.../package` as we might expect. I suspect this is confusing `github-post` when it tries to find tests in the `package_test` directory rather than the `package` directory. We address this by allowing `github-post` to search up the directory tree for the test rather than expecting it to be in one particular directory. Also update a repro command to use `dev test` rather than `make stressrace`. Closes cockroachdb#85420. Release justification: Non-production code changes Release note: None
f9f1722 to
c4e95f0
Compare
Collaborator
Author
|
TFTR! bors r=srosenberg,rail |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the Bazel test runner "incorrectly" reports the package
path for tests. For example, we have issues where the name of
the test is reported as
pkg/.../package/package_testrather thanpkg/.../packageas we might expect. I suspect this is confusinggithub-postwhen it tries to find tests in thepackage_testdirectory rather than the
packagedirectory.We address this by allowing
github-postto search up the directorytree for the test rather than expecting it to be in one particular
directory.
Also update a repro command to use
dev testrather thanmake stressrace.Closes #85420.
Release justification: Non-production code changes
Release note: None