bazel: set GORACE variable appropriately when testing w/ race#87130
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 31, 2022
Merged
bazel: set GORACE variable appropriately when testing w/ race#87130craig[bot] merged 1 commit intocockroachdb:masterfrom
GORACE variable appropriately when testing w/ race#87130craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
By default the `race` data is output to `stderr`, which means it ends up in the `test.log` file but NOT the `test.xml` file. Changing it to `stdout` means that this instead ends up `test.xml` as well as `test.log` and any output JSON files. Closes cockroachdb#74105. Release justification: Non-production code changes Release note: None
rail
approved these changes
Aug 30, 2022
srosenberg
approved these changes
Aug 30, 2022
Member
srosenberg
left a comment
There was a problem hiding this comment.
Will this also resolve the nightly stressrace job? I believe it gets its parameters from env.EXTRA_BAZEL_FLAGS If both are addressed, then in theory this longstanding issue should be resolved: #69534
Collaborator
Author
Collaborator
Author
|
bors r=rail,srosenberg |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the
racedata is output tostderr, which means it ends upin the
test.logfile but NOT thetest.xmlfile. Changing it tostdoutmeans that this instead ends uptest.xmlas well astest.logand any output JSON files.Closes #74105.
Release justification: Non-production code changes
Release note: None