sql: slight refactor to audit logging code#86791
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 25, 2022
Merged
sql: slight refactor to audit logging code#86791craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
Release justification: Small refactor, no functionality change Release note: None
cbdaccb to
badf22d
Compare
rafiss
approved these changes
Aug 24, 2022
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
refactor lgtm, but i'm a bit surprised that it was only logging INSERT, DELETE , and UPDATE on tables. do you know why not the other privs?
Contributor
Author
It does log it, from what I understand, we either log "READWRITE" for those 3 and "READ" for everything else. I suppose it could have been more granular but I'm not familiar with the historical context. |
Contributor
Author
|
Thanks! bors r=rafiss |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release justification: Small refactor, no functionality change
Release note: None
Fixes #84760