86604: scbuildstmt: added cluster version gating for declarative schema changer r=Xiang-Gu a=Xiang-Gu For each implemented DDL stmt in the new schema changer, we added a minimal supported cluster version so that we can return an unimplemented error when the cluster version is lower than the minimal supported cluster version of that DDL statement. This will be useful in mixed-version cluster where we make sure we don't use new schema changer for statements that are only supported in v22.2, but not in v22.1. Partially fix #79840 Release justification: improve safety and prevent issues in mixed-version cluster. Release note: None 86605: builtins: don't panic on placeholders in bounded staleness function r=rafiss a=rafiss fixes #86243 Release note (bug fix): Fixed a crash/panic that could occur if placeholder arguments were used with the with_min_timestamp or with_max_staleness functions. Release justification: Fix a crash caused by a panic. 86607: sql: add nil guard when formatting placeholders r=rafiss a=rafiss Fixes #85363 Release note (bug fix): Fixed a crash that could happen when formatting queries that have placeholder BitArray arguments. Release justification: Fix a panic. 86634: sql: remove sql.defaults.optimizer_use_not_visible_indexes.enabled r=mgartner,wenyihu6,rafiss a=michae2 **sql: remove sql.defaults.optimizer_use_not_visible_indexes.enabled** In 22.2 the use of cluster settings for session setting defaults is deprecated, but I forgot this when reviewing #86033. Remove the unreleased default cluster setting we added. Release note: None **sql: add more session variables to statement bundles** Add some missing session variables to statement diagnostic bundles. This isn't quite everything, but it's better than what we had before. Release note: None ---- Release justification: low-risk bug fix. 86673: insights: enable the anomaly detector r=matthewtodd a=matthewtodd This change turns on the insights "anomaly detector" by default, catching statement executions in the >p99 latency for their fingerprint that are also far enough away from median latency and above a (default 50ms) threshold. Release justification: Category 2: Bug fixes and low-risk updates to new functionality. Release note (ops change): The `sql.insights.anomaly_detection.enabled` cluster setting now defaults to true, and the `sql.insights.anomaly_detection.latency_threshold` cluster setting now defaults to 50ms, down from 100ms to complement the fixed-threshold detector's default of 100ms. 86722: opt: don't mark st_makeline and st_extend as non-null r=DrewKimball a=DrewKimball `st_makeline` can take arguments of type `POINT`, `MULTIPOINT`, and `LINESTRING`. Other types cause it to return null (even if the input is non-null). Similarly, `st_extent` returns null when the input geometry is non-null, but empty. This commit prevents these two aggregate functions from being marked as non-null, since doing so can lead to incorrect results in the cases mentioned above. Fixes #84957 Release justification: low-risk fix to bug that can lead to incorrect results Release note (bug fix): Fixed a longstanding bug that could cause the optimizer to produce an incorrect plan when aggregate functions `st_makeline` or `st_extent` were called with invalid-type and empty inputs respectively. 86747: ui: fix typo r=maryliag a=maryliag Fix typo on Execution Index Recommendation text, using singular or plural accordingly. Release justification: low risk change Release note: None 86791: sql: slight refactor to audit logging code r=rafiss a=RichardJCai Release justification: Small refactor, no functionality change Release note: None Fixes #84760 Co-authored-by: Xiang Gu <xiang@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Michael Erickson <michae2@cockroachlabs.com> Co-authored-by: Matthew Todd <todd@cockroachlabs.com> Co-authored-by: DrewKimball <drewk@cockroachlabs.com> Co-authored-by: Marylia Gutierrez <marylia@cockroachlabs.com> Co-authored-by: richardjcai <caioftherichard@gmail.com>

sql: audit logging for synthetic privileges #84760

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions