kvserver: default admission.kv.pause_replication_io_threshold to 0.8#86147
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 15, 2022
Merged
kvserver: default admission.kv.pause_replication_io_threshold to 0.8#86147craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Member
Author
|
going to wait for #85739 |
erikgrinaker
approved these changes
Aug 15, 2022
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
The cluster setting can be disabled by setting a high value of, say, 10000.
The description says "zero to disable". Is this no longer accurate? I'd intuitively assume that was the case.
Closes cockroachdb#83920. Release note (ops change): The `admission.kv.pause_replication_threshold` cluster setting is now set to a default value of 0.8. On a fully migrated v22.2+ deployment, this will allow the KV layer to pause replication streams to followers located on stores that are close to activating their I/O admission control subsystem (thereby protecting these followers from additional overload). The cluster setting can be disabled by setting it to zero.
654e314 to
1fa00d4
Compare
Member
Author
|
That just changed in #85739, but I didn't update the description. I did that because (at least at some point) the cluster setting was read in two places and it was bug prone to have to special case zero. But now we only query it in one place; brought back the special casing and adjusted the release note. bors r=erikgrinaker |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
irfansharif
reviewed
Aug 18, 2022
Contributor
irfansharif
left a comment
There was a problem hiding this comment.
The release note has a typo in the cluster setting that might make it to public docs. It needs to be admission.kv.pause_replication_io_threshold.
This was referenced Aug 24, 2022
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Aug 24, 2022
(Morally) reverts cockroachdb#86147. We'll roll this setting out over time. See: cockroachdb#86775 Release justification: more conservative choice for a new cluster setting Release note (ops change): the admission.kv.pause_replication_io_threshold cluster setting now default to zero (off). This supersedes an earlier release note about this setting.
craig bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
86625: roachtest: compile cockroach-short with --crdb_test and use in sqlsmith r=yuzefovich a=yuzefovich This commit adds another step to the nightly roachtest invocation to compile `cockroach-short` binary with `--crdb_test` build tag. Then it also adds plumbing throughout the roachtest infrastructure to expose that newly-compiled binary which is now used in 50% cases in the sqlsmith roachtest. Fixes: #83186. Release justification: testing-only change. Release note: None 86675: builtins: fix json_build_object for enums and void in the key r=yuzefovich a=yuzefovich Previously, we would run into an internal error with `json_build_object` builtin if an enum or void was passed for the key part, and this is now fixed. This commit also sorts all datums lexicographically to make it easier to see whether all scalar datums are mentioned. Fixes: #84368. Release justification: bug fix. Release note (bug fix): Previously, CockroachDB would return an internal error when evaluating `json_build_object` builtin when an enum or a void datums were passed as the first argument, and this is now fixed. 86759: storage: implement `String()` for `MVCCRangeKeyStack` r=jbowens a=erikgrinaker Release justification: bug fixes and low-risk updates to new functionality Release note: None 86776: kvserver: disable replica pausing by default r=erikgrinaker a=tbg (Morally) reverts #86147. We'll roll this setting out over time. See: #86775 Release justification: more conservative choice for a new cluster setting Release note (ops change): the admission.kv.pause_replication_io_threshold cluster setting now default to zero (off). This supersedes an earlier release note about this setting. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83920.
Release note (ops change): The
admission.kv.pause_replication_thresholdcluster setting is now set toa default value of 0.8. On a fully migrated v22.2+ deployment, this will
allow the KV layer to pause replication streams to followers located on
stores that are close to activating their I/O admission control
subsystem (thereby protecting these followers from additional overload).
The cluster setting can be disabled by setting to zero.
Release justification: enables new functionality